Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bool option for automount_service_account_token #571

Conversation

davidholsgrove
Copy link
Contributor

Allow setting kubernetes service account resource attribute automount_service_account_token

bharathkkb
bharathkkb previously approved these changes Jun 22, 2020
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! 🚀

@davidholsgrove
Copy link
Contributor Author

Thanks @bharathkkb - I see one of the checks timed out, does it need to be rerun?

@bharathkkb
Copy link
Member

fix for lint test timing out is in #538 so I think this should be okay.

@bharathkkb bharathkkb requested a review from morgante June 23, 2020 04:21
@morgante morgante merged commit 002cfb1 into terraform-google-modules:master Jun 25, 2020
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants