Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Terraform 0.12. Add health_check parameter. #12

Merged
merged 12 commits into from
Nov 4, 2019
Merged

Upgrade to Terraform 0.12. Add health_check parameter. #12

merged 12 commits into from
Nov 4, 2019

Conversation

omazin
Copy link
Contributor

@omazin omazin commented Oct 23, 2019 •
edited
Loading

Fixes #10, #3, #9

@omazin
Upgrade to Terraform 0.12. Fix terraform-google-modules#10. Add healt…
3a8b439 
…h_check parameter. Fix terraform-google-modules#3. Remove http_health_check, health_port inputs. Modify example. Fix terraform-google-modules#9.
@omazin
Copy link
Contributor Author

omazin commented Oct 23, 2019

Note, that the example requires the latest terraform-google-vm module that hasn’t been released yet. In particular, it relies on the project_id parameter added in this commit terraform-google-modules/terraform-google-vm@d246bd3

@aaron-lane aaron-lane added the enhancement New feature or request label Oct 23, 2019
aaron-lane
aaron-lane suggested changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @omazin!

examples/simple/main.tf Outdated Show resolved Hide resolved
examples/simple/main.tf Outdated Show resolved Hide resolved
examples/simple/main.tf Outdated Show resolved Hide resolved
examples/simple/main.tf Outdated Show resolved Hide resolved
examples/simple/main.tf Outdated Show resolved Hide resolved
examples/simple/variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
aaron-lane
aaron-lane suggested changes Oct 23, 2019
View reviewed changes
examples/simple/mig.tf Show resolved Hide resolved
@paulpalamarchuk paulpalamarchuk mentioned this pull request Oct 25, 2019
Closed
@omazin
Copy link
Contributor Author

omazin commented Oct 25, 2019 •
edited
Loading

Noticed that the zone input was dropped from the mig module, couldn't find the input in the instance_template module as well, so couldn't pass it the way it was passed before https://github.com/terraform-google-modules/terraform-google-lb-internal/blob/master/examples/simple/mig.tf#L45

aaron-lane
aaron-lane suggested changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @omazin!

Just a pair of minor changes requested.

docs/upgrading_to_lb_internal_v2.0.md Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@aaron-lane aaron-lane merged commit ae94507 into terraform-google-modules:master Nov 4, 2019
This was referenced Nov 5, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-lane aaron-lane aaron-lane approved these changes

Assignees

@aaron-lane aaron-lane

@omazin omazin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Terraform 0.12
2 participants
@omazin @aaron-lane