Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support http health check request_path #2

Conversation

mDantas
Copy link

@mDantas mDantas commented May 24, 2018

Hello!

I'm building here on the recent addition of support for http health checks. Namely, I'm adding a variable to specify the path at which to perform the http health check (as terraform-google-lb-http supports).

This seemed like the minimal change to achieve this functionality. I can see the argument for doing some refactoring and accepting a backend_params array instead as is the case with terraform-google-lb-http. Let me know how you'd like to proceed.

Thanks,
Matt

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@mDantas
Copy link
Author

mDantas commented May 24, 2018

PS - I'm working on getting approval from my org to sign the CLA.

@omazin
Copy link
Contributor

omazin commented Nov 5, 2019

@aaron-lane think this can be closed since more parameters to health checks were added in #12

@morgante
Copy link
Contributor

morgante commented Nov 5, 2019

@mDantas Please reopen if your requirements weren't addressed.

@morgante morgante closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants