Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: output kafka_brokers_sasl #341

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

JunliWang
Copy link
Contributor

@JunliWang JunliWang commented Nov 18, 2024

Description

this PR was not correct
instance.extensions is a map, kafka_brokers_sasl is a list inside the map, terraform has flatten this list into
kafka_brokers_sasl.0, kafka_brokers_sasl.1, etc when output this map, so key kafka_brokers_sasl does not exist in the map.

the fix is iterate the number of brokers to get correct keys from the map and construct the list.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@JunliWang
Copy link
Contributor Author

/run pipeline

@JunliWang
Copy link
Contributor Author

/run pipeline

@JunliWang
Copy link
Contributor Author

the output looks good to me from the test

TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66: Outputs:
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66: 
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66: crn = "crn:v1:bluemix:public:messagehub:us-south:a/abac0df06b644a9cabc6e44f55b3880e:aa75d564-f802-4b16-ad65-2f157e7e2120::"
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66: guid = "aa75d564-f802-4b16-ad65-2f157e7e2120"
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66: kafka_broker_version = "3.6"
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66: kafka_brokers_sasl = [
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66:   "broker-3-y8042l7vftjcsnwd.kafka.svc03.us-south.eventstreams.cloud.ibm.com:9093",
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66:   "broker-5-y8042l7vftjcsnwd.kafka.svc03.us-south.eventstreams.cloud.ibm.com:9093",
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66:   "broker-0-y8042l7vftjcsnwd.kafka.svc03.us-south.eventstreams.cloud.ibm.com:9093",
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66:   "broker-4-y8042l7vftjcsnwd.kafka.svc03.us-south.eventstreams.cloud.ibm.com:9093",
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66:   "broker-2-y8042l7vftjcsnwd.kafka.svc03.us-south.eventstreams.cloud.ibm.com:9093",
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66:   "broker-1-y8042l7vftjcsnwd.kafka.svc03.us-south.eventstreams.cloud.ibm.com:9093",
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66: ]
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66: kafka_http_url = "https://y8042l7vftjcsnwd.svc03.us-south.eventstreams.cloud.ibm.com/"
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66: resource_group_id = "edbac64c0068438fa9ff19665d648f64"
TestRunQuickstartSolution 2024-11-18T17:56:45Z logger.go:66: resource_group_name = "geretain-test-event-streams"
TestRunQuickstartSolution 2024-11-18T17:56:45Z tests.go:880: FINISHED: Init / Apply

@ocofaigh
Copy link
Member

/run pipeline

@ocofaigh ocofaigh merged commit 59754d9 into terraform-ibm-modules:main Nov 19, 2024
2 checks passed
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants