feat: add LFP Battery setting for car settings #4007

cwanja · 2024-06-27T02:22:57Z

Disclosure this is not complete in anyway. This adds the settings and updates the webpage. I created this PR based upon a413e8c from @adriankumpf and my work on #2727.

What is missing is:

Dashboards. @swiffer mentioned he would work on those
All the updates to "LC_Messages" - no clue what these are 🤷🏼

Do your worst!

Edit: moving to "completed" from my original post:
Completed after original push

Migration scripts - Can someone validate this? Based it upon a457d17 where the streaming api setting was created.
Test scripts - attempted in 7604d17 (Edit: and then many more 😄 but got it working! 🥳 ).

Add LFP battery toggle to settings page

Update car settings to store LFP battery setting

Formatting

Add migration scripts to create column in car settings

netlify · 2024-06-27T02:23:11Z

✅ Deploy Preview for teslamate ready!

Name	Link
🔨 Latest commit	`c1bf616`
🔍 Latest deploy log	https://app.netlify.com/sites/teslamate/deploys/6685dda67bb3ea0008d507eb
😎 Deploy Preview	https://deploy-preview-4007--teslamate.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cwanja · 2024-06-27T02:24:37Z

Since we are just creating a toggle, does Tesla have any documentation we can link to for a user to check if their car is a LFP battery or not?

Added test settings for LFP Battery

Update migrations script to proper name defmodule.

Updated test scripts

Fix get default settings test

cwanja · 2024-06-27T03:08:52Z

@mark3-dev - really dumb question. But what updates do I need to do to the default.pot files? It looks like random numbers are added to the end of lines. Mimicking your PR #3993

mark3-dev · 2024-06-27T11:17:18Z

@mark3-dev - really dumb question. But what updates do I need to do to the default.pot files? It looks like random numbers are added to the end of lines. Mimicking your PR #3993

@cwanja Those numbers are the line numbers of where the gettext translations are used. You can update the pot files by following this https://docs.teslamate.org/docs/development#update-pot-files-extract-messages-for-translation

cwanja · 2024-06-28T18:52:34Z

@mark3-dev - really dumb question. But what updates do I need to do to the default.pot files? It looks like random numbers are added to the end of lines. Mimicking your PR #3993

@cwanja Those numbers are the line numbers of where the gettext translations are used. You can update the pot files by following this https://docs.teslamate.org/docs/development#update-pot-files-extract-messages-for-translation

Thanks @mark3-dev. Feel like I know the answer here, but will ask anyways. Is there any way execute this from the GUI in the branch? Might be crazy to say, but I have modified the code in GitHub UI. I do not have a local repo or anything.

mark3-dev · 2024-06-28T23:23:39Z

@mark3-dev - really dumb question. But what updates do I need to do to the default.pot files? It looks like random numbers are added to the end of lines. Mimicking your PR #3993

@cwanja Those numbers are the line numbers of where the gettext translations are used. You can update the pot files by following this https://docs.teslamate.org/docs/development#update-pot-files-extract-messages-for-translation

Thanks @mark3-dev. Feel like I know the answer here, but will ask anyways. Is there any way execute this from the GUI in the branch? Might be crazy to say, but I have modified the code in GitHub UI. I do not have a local repo or anything.

@cwanja I'm not sure if there is any other way to do it other than pulling down the files and running it.

07stuntar1 · 2024-06-29T21:34:10Z

I pulled the PR where is to toggle located? My car isnt LFP but was plotting on Battery Health LFP so now theres no data when I click Battery Health. It's still not plotting on the battery health page.

swiffer · 2024-06-30T15:45:23Z

@07stuntar1 - as we've said - in terms of data there is no difference between LFP / non-LFP. The only difference that has been make back then was in terms of how the data is visualized. You seem to are operating on different databases.

07stuntar1 · 2024-06-30T18:19:48Z

@07stuntar1 - as we've said - in terms of data there is no difference between LFP / non-LFP. The only difference that has been make back then was in terms of how the data is visualized. You seem to are operating on different databases.

How can I fix it? The rest of the pages data is fine. It’s just the battery page

cwanja · 2024-07-03T18:54:58Z

Raising my hand here - I am at a loss for running the pots update. I tried through VS code and GitHub codespaces. Could not get mix working. If there is a way to add a collaborator on this branch, please let me know. Otherwise, someone can open a new branch and use my changes as a baseline to get this added.

Sorry about that.

cwanja · 2024-07-03T23:27:47Z

Welp. I have no clue how I did it. But I did 🍾

Can someone review and test? @JakobLichterfeld @swiffer

JakobLichterfeld

Awesome, lgtm

JakobLichterfeld · 2024-07-04T08:00:46Z

Successfully tested

Migration
Setting
Dashboard --> Integrate LFP specific dashboards into regular dashboards #3966

swiffer · 2024-07-04T08:40:53Z

Will take care of changing dashboards after merge!

JakobLichterfeld · 2024-07-05T07:25:47Z

Sorry, due to merging #3993, may I ask you to update the pot again? And merge the settings_test? Sorry for the inconvenience.

JakobLichterfeld · 2024-07-05T16:21:23Z

Sorry, due to merging #3993, may I ask you to update the pot again? And merge the settings_test? Sorry for the inconvenience.

I try to solve it via a separate branch as I do not have write access to your repo.

* Update index.html.heex Add LFP battery toggle to settings page * Update car_settings.ex Update car settings to store LFP battery setting * Update car_settings.ex Formatting * Create 20240627021414_add_lfp_battery_car_setting.exs Add migration scripts to create column in car settings * Update settings_test.exs Added test settings for LFP Battery * Update 20240627021414_add_lfp_battery_car_setting.exs Update migrations script to proper name defmodule. * Update settings_test.exs Updated test scripts * Update settings_test.exs Fix get default settings test * "Commit pots files"

cwanja added 4 commits June 26, 2024 21:00

Update index.html.heex

86970ef

Add LFP battery toggle to settings page

Update car_settings.ex

a6eac13

Update car settings to store LFP battery setting

Update car_settings.ex

e4685ab

Formatting

Create 20240627021414_add_lfp_battery_car_setting.exs

676ffb4

Add migration scripts to create column in car settings

cwanja added WIP Work in progress area:dashboard Related to a Grafana dashboard area:teslamate Related to TeslaMate core labels Jun 27, 2024

cwanja changed the title ~~[WIP] feat: add LFP Battery for car settings~~ [WIP] feat: add LFP Battery setting for car settings Jun 27, 2024

cwanja mentioned this pull request Jun 27, 2024

Integrate LFP specific dashboards into regular dashboards #3966

Merged

cwanja added 4 commits June 26, 2024 21:32

Update settings_test.exs

7604d17

Added test settings for LFP Battery

Update 20240627021414_add_lfp_battery_car_setting.exs

293daaf

Update migrations script to proper name defmodule.

Update settings_test.exs

fd9ce29

Updated test scripts

Update settings_test.exs

5c2c2d1

Fix get default settings test

JakobLichterfeld linked an issue Jul 2, 2024 that may be closed by this pull request

feat: use variables in grafana dashboards for battery type #3438

Closed

1 task

cwanja added 2 commits July 3, 2024 15:08

Merge branch 'teslamate-org:master' into cwanja-LFP-battery-setting

3746bf4

"Commit pots files"

c1bf616

cwanja requested a review from JakobLichterfeld July 3, 2024 23:27

cwanja removed the WIP Work in progress label Jul 3, 2024

cwanja changed the title ~~[WIP] feat: add LFP Battery setting for car settings~~ feat: add LFP Battery setting for car settings Jul 3, 2024

cwanja requested a review from brianmay July 3, 2024 23:29

cwanja mentioned this pull request Jul 4, 2024

[dev] Unable to establish code space; postgres user / password not established #4032

Open

1 task

JakobLichterfeld approved these changes Jul 4, 2024

View reviewed changes

JakobLichterfeld changed the base branch from master to feat-lfp-setting July 5, 2024 16:20

JakobLichterfeld merged commit 30c0cbb into teslamate-org:feat-lfp-setting Jul 5, 2024
12 checks passed

JakobLichterfeld mentioned this pull request Jul 5, 2024

feat: add LFP Battery setting for car settings #4036

Closed

JakobLichterfeld added a commit that referenced this pull request Jul 5, 2024

feat: add LFP Battery setting for car settings (#4007) -> master

00fdadc

JakobLichterfeld mentioned this pull request Jul 5, 2024

feat: add LFP Battery setting for car settings #4038

Merged

cwanja deleted the cwanja-LFP-battery-setting branch July 6, 2024 00:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add LFP Battery setting for car settings #4007

feat: add LFP Battery setting for car settings #4007

cwanja commented Jun 27, 2024 •

edited

Loading

netlify bot commented Jun 27, 2024 •

edited

Loading

cwanja commented Jun 27, 2024 •

edited

Loading

cwanja commented Jun 27, 2024

mark3-dev commented Jun 27, 2024

cwanja commented Jun 28, 2024

mark3-dev commented Jun 28, 2024

07stuntar1 commented Jun 29, 2024 •

edited

Loading

swiffer commented Jun 30, 2024

07stuntar1 commented Jun 30, 2024

cwanja commented Jul 3, 2024 •

edited

Loading

cwanja commented Jul 3, 2024

JakobLichterfeld left a comment

JakobLichterfeld commented Jul 4, 2024 •

edited

Loading

swiffer commented Jul 4, 2024

JakobLichterfeld commented Jul 5, 2024

JakobLichterfeld commented Jul 5, 2024

feat: add LFP Battery setting for car settings #4007

feat: add LFP Battery setting for car settings #4007

Conversation

cwanja commented Jun 27, 2024 • edited Loading

netlify bot commented Jun 27, 2024 • edited Loading

✅ Deploy Preview for teslamate ready!

cwanja commented Jun 27, 2024 • edited Loading

cwanja commented Jun 27, 2024

mark3-dev commented Jun 27, 2024

cwanja commented Jun 28, 2024

mark3-dev commented Jun 28, 2024

07stuntar1 commented Jun 29, 2024 • edited Loading

swiffer commented Jun 30, 2024

07stuntar1 commented Jun 30, 2024

cwanja commented Jul 3, 2024 • edited Loading

cwanja commented Jul 3, 2024

JakobLichterfeld left a comment

Choose a reason for hiding this comment

JakobLichterfeld commented Jul 4, 2024 • edited Loading

swiffer commented Jul 4, 2024

JakobLichterfeld commented Jul 5, 2024

JakobLichterfeld commented Jul 5, 2024

cwanja commented Jun 27, 2024 •

edited

Loading

netlify bot commented Jun 27, 2024 •

edited

Loading

cwanja commented Jun 27, 2024 •

edited

Loading

07stuntar1 commented Jun 29, 2024 •

edited

Loading

cwanja commented Jul 3, 2024 •

edited

Loading

JakobLichterfeld commented Jul 4, 2024 •

edited

Loading