feat: add LFP Battery setting for car settings #4036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update index.html.heex Add LFP battery toggle to settings page * Update car_settings.ex Update car settings to store LFP battery setting * Update car_settings.ex Formatting * Create 20240627021414_add_lfp_battery_car_setting.exs Add migration scripts to create column in car settings * Update settings_test.exs Added test settings for LFP Battery * Update 20240627021414_add_lfp_battery_car_setting.exs Update migrations script to proper name defmodule. * Update settings_test.exs Updated test scripts * Update settings_test.exs Fix get default settings test * "Commit pots files"
* Add ability to enable and disable cars * Add default value for enabled in car_settings. * Fix unit tests. * Fix formatting. * Update text to be more descriptive * Update lables.
New version based on latest master
* Update index.html.heex Add LFP battery toggle to settings page * Update car_settings.ex Update car settings to store LFP battery setting * Update car_settings.ex Formatting * Create 20240627021414_add_lfp_battery_car_setting.exs Add migration scripts to create column in car settings * Update settings_test.exs Added test settings for LFP Battery * Update 20240627021414_add_lfp_battery_car_setting.exs Update migrations script to proper name defmodule. * Update settings_test.exs Updated test scripts * Update settings_test.exs Fix get default settings test * "Commit pots files"
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
succesor of #4007