Use delivery channel to get kafka producer metrics #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agbpatro
force-pushed
the
use_delivery_channel
branch
2 times, most recently
from
ec771d4
to
316273b
Compare
agbpatro
changed the title
agbpatro
force-pushed
the
use_delivery_channel
branch
2 times, most recently
from
de714ad
to
7fdb73e
Compare
aaronpkahn
reviewed
Apr 17, 2024
datastore/kafka/kafka.go
Outdated
| @@ -58,9 +60,11 @@ func NewProducer(config *kafka.ConfigMap, namespace string, reliableAckWorkers i | |||
| logger: logger, | |||
| airbrakeHandler: airbrakeHandler, | |||
| reliableAck: reliableAckWorkers > 0, | |||
| deliveryChan: make(chan kafka.Event), | |||
| ackChan: ackChan, | |||
There was a problem hiding this comment.
I don't understand this design for ackChan. Wouldn't we need an ackChan per connection?
There was a problem hiding this comment.
you are right. I have disabled setting reliable ack config for now. Will remove the restriction when its supported properly
There was a problem hiding this comment.
ok, well we should complete the implementation or remove ackChan. Let's not leave code/variables around that aren't being used
agbpatro
force-pushed
the
use_delivery_channel
branch
2 times, most recently
from
8ac098c
to
8e96daa
Compare
Confluent provides the channel interface to get delivery reports We should use that to get kafka metrics Add more metrics for other failure mode Disable reliable acks since it will not work as expected
agbpatro
force-pushed
the
use_delivery_channel
branch
from
8e96daa
to
213a13a
Compare
aaronpkahn
approved these changes
Apr 17, 2024
| @@ -54,6 +55,10 @@ func loadApplicationConfig(configFilePath string) (*Config, error) { | |||
| } | |||
| config.MetricCollector = metrics.NewCollector(config.Monitoring, logger) | |||
|
|
|||
| // TODO disble this check when reliable acks are properly supported | |||
There was a problem hiding this comment.
When is this going to be?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Confluent provides the channel interface to get delivery reports. We should use that to get kafka metrics
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: