-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use delivery channel to get kafka producer metrics #162
Conversation
ec771d4
to
316273b
Compare
de714ad
to
7fdb73e
Compare
datastore/kafka/kafka.go
Outdated
@@ -58,9 +60,11 @@ func NewProducer(config *kafka.ConfigMap, namespace string, reliableAckWorkers i | |||
logger: logger, | |||
airbrakeHandler: airbrakeHandler, | |||
reliableAck: reliableAckWorkers > 0, | |||
deliveryChan: make(chan kafka.Event), | |||
ackChan: ackChan, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this design for ackChan. Wouldn't we need an ackChan per connection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right. I have disabled setting reliable ack config for now. Will remove the restriction when its supported properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, well we should complete the implementation or remove ackChan. Let's not leave code/variables around that aren't being used
8ac098c
to
8e96daa
Compare
Confluent provides the channel interface to get delivery reports We should use that to get kafka metrics Add more metrics for other failure mode Disable reliable acks since it will not work as expected
8e96daa
to
213a13a
Compare
@@ -54,6 +55,10 @@ func loadApplicationConfig(configFilePath string) (*Config, error) { | |||
} | |||
config.MetricCollector = metrics.NewCollector(config.Monitoring, logger) | |||
|
|||
// TODO disble this check when reliable acks are properly supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When is this going to be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Confluent provides the channel interface to get delivery reports. We should use that to get kafka metrics
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: