-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reliable acks based on configuration #167
Conversation
96d46e5
to
067a332
Compare
6731126
to
e9ebd90
Compare
datastore/kafka/kafka.go
Outdated
airbrakeHandler *airbrake.AirbrakeHandler | ||
deliveryChan chan kafka.Event | ||
ackChan chan (*telemetry.Record) | ||
reliableAckTxTypes []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: could make this a map instead of a slice and it would improve code readability in ProcessReliableAck
, probably no performance improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought about that but didn't implement it since there was no performance improvement. From readability POV, it makes sense. Updated!
Expect(err).NotTo(HaveOccurred()) | ||
actualTxType := string(streamMessage.MessageTopic) | ||
Expect(actualTxType).To(Equal(expectedTxType)) | ||
Expect(streamMessage.TXID).To(Equal([]byte("integration-test-txid"))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
e9ebd90
to
6cc2278
Compare
Implement reliable acks in fleet telemetry which will allow to signal back to the vehicle that the request was processed successfully
6cc2278
to
a276549
Compare
Description
Implement reliable acks in fleet telemetry which will allow to signal back to the vehicle that the request was processed successfully
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: