Add support for reliable acks based on configuration #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agbpatro
force-pushed
the
implement_reliable_acks
branch
12 times, most recently
from
96d46e5
to
067a332
Compare
9 tasks
agbpatro
force-pushed
the
implement_reliable_acks
branch
5 times, most recently
from
6731126
to
e9ebd90
Compare
agbpatro
requested review from
ThomasAlxDmy,
vmallet,
aaronpkahn and
patrickdemers6
aaronpkahn
reviewed
Apr 23, 2024
datastore/kafka/kafka.go
Outdated
| airbrakeHandler *airbrake.AirbrakeHandler | ||
| deliveryChan chan kafka.Event | ||
| ackChan chan (*telemetry.Record) | ||
| reliableAckTxTypes []string |
There was a problem hiding this comment.
minor: could make this a map instead of a slice and it would improve code readability in ProcessReliableAck, probably no performance improvement.
There was a problem hiding this comment.
i thought about that but didn't implement it since there was no performance improvement. From readability POV, it makes sense. Updated!
aaronpkahn
reviewed
Apr 23, 2024
| Expect(err).NotTo(HaveOccurred()) | ||
| actualTxType := string(streamMessage.MessageTopic) | ||
| Expect(actualTxType).To(Equal(expectedTxType)) | ||
| Expect(streamMessage.TXID).To(Equal([]byte("integration-test-txid"))) |
aaronpkahn
approved these changes
Apr 23, 2024
agbpatro
force-pushed
the
implement_reliable_acks
branch
from
e9ebd90
to
6cc2278
Compare
Implement reliable acks in fleet telemetry which will allow to signal back to the vehicle that the request was processed successfully
agbpatro
force-pushed
the
implement_reliable_acks
branch
from
6cc2278
to
a276549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement reliable acks in fleet telemetry which will allow to signal back to the vehicle that the request was processed successfully
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: