Use latest tag as default if no tag is specified (#744)

Fixes #676
testcontainers · Jun 13, 2018 · 360702a · 360702a
1 parent 5cdd8dc
commit 360702a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/core/src/main/java/org/testcontainers/utility/DockerImageName.java b/core/src/main/java/org/testcontainers/utility/DockerImageName.java
@@ -45,7 +45,7 @@ public DockerImageName(String name) {
             versioning = new TagVersioning(remoteName.split(":")[1]);
         } else {
             repo = remoteName;
-            versioning = null;
+            versioning = new TagVersioning("latest");
         }
     }
 

diff --git a/core/src/test/java/org/testcontainers/dockerclient/ImagePullTest.java b/core/src/test/java/org/testcontainers/dockerclient/ImagePullTest.java
@@ -16,6 +16,7 @@ public static String[] parameters() {
         return new String[] {
             "alpine:latest",
             "alpine:3.6",
+            "alpine", // omitting the tag should work and default to latest
             "alpine@sha256:8fd4b76819e1e5baac82bd0a3d03abfe3906e034cc5ee32100d12aaaf3956dc7",
             "gliderlabs/alpine:latest",
             "gliderlabs/alpine:3.5",

diff --git a/core/src/test/java/org/testcontainers/utility/DockerImageNameTest.java b/core/src/test/java/org/testcontainers/utility/DockerImageNameTest.java
@@ -24,7 +24,6 @@ public void validNames() {
 
     @Test
     public void invalidNames() {
-        testInvalid("myname");
         testInvalid(":latest");
         testInvalid("/myname:latest");
         testInvalid("/myname@sha256:latest");