Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest tag as default if no tag is specified #744

Merged
merged 2 commits into from
Jun 13, 2018
Merged

Use latest tag as default if no tag is specified #744

merged 2 commits into from
Jun 13, 2018

Conversation

kiview
Copy link
Member

@kiview kiview commented Jun 12, 2018

An alternative would be to throw an error since I don't see a case, where setting the versioning to null makes sense?

Fixes #676

@kiview kiview requested a review from bsideup June 12, 2018 12:11
@kiview kiview requested a review from rnorth as a code owner June 12, 2018 12:11
@kiview
Copy link
Member Author

kiview commented Jun 12, 2018

I just found the DockerImageNameTest class. Should I move the test from ImagePullTest (integration test like) to DockerImageNameTest?

@kiview kiview merged commit 360702a into master Jun 13, 2018
@kiview kiview deleted the latest-tag-default branch June 13, 2018 07:49
@bsideup bsideup added this to the next milestone Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiview @bsideup