Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded images #259

Closed
mabn opened this issue Jan 2, 2017 · 1 comment
Closed

hardcoded images #259

mabn opened this issue Jan 2, 2017 · 1 comment
Assignees
Milestone

Comments

@mabn
Copy link

mabn commented Jan 2, 2017

Some classes use hardcoded images which makes it impossible to use testcontainers with private registry. In particular richnorth/ambassador:latest.

It should be adjustable, e.g. via a config file or env variable. Or with additional parameters to junit rules.

Also:
richnorth/vnc-recorder:latest

@rnorth
Copy link
Member

rnorth commented Jan 14, 2017

@mabn thanks, yes, it's probably about time to make these configurable. I think a config file on the classpath would be the right answer.

@rnorth rnorth self-assigned this Jan 21, 2017
rnorth added a commit that referenced this issue Jan 21, 2017
…th file

Replace static string names for ambassador and vnc recorder container images with classpath lookup.

Add note to readme re overriding hardcoded image names

Refs #259, #276
rnorth added a commit that referenced this issue Jan 21, 2017
…th file

Replace static string names for ambassador and vnc recorder container images with classpath lookup.

Add note to readme re overriding hardcoded image names

Refs #259, #276
rnorth added a commit that referenced this issue Jan 22, 2017
…th file

Replace static string names for ambassador and vnc recorder container images with classpath lookup.

Add note to readme re overriding hardcoded image names

Refs #259, #276
rnorth added a commit that referenced this issue Jan 22, 2017
…th file

Replace static string names for ambassador and vnc recorder container images with classpath lookup.

Add note to readme re overriding hardcoded image names

Refs #259, #276
rnorth added a commit that referenced this issue Jan 22, 2017
…th file

Replace static string names for ambassador and vnc recorder container images with classpath lookup.

Add note to readme re overriding hardcoded image names

Refs #259, #276
@rnorth rnorth modified the milestone: 1.1.8 Jan 22, 2017
@rnorth rnorth closed this as completed Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants