Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utility container images with latest tags should be replaced by a versioned image #276

Closed
rnorth opened this issue Jan 21, 2017 · 1 comment
Closed

Utility container images with latest tags should be replaced by a versioned image #276

rnorth opened this issue Jan 21, 2017 · 1 comment
Milestone
1.1.8

Comments

@rnorth
Copy link
Member

rnorth commented Jan 21, 2017

richnorth/ambassador:latest and richnorth/vncrecorder:latest can't be safely upgraded because Testcontainers uses the 'latest' tag. As such, for a future version of Testcontainers we should create new container images within a new namespace, and set an explicit version number.
rnorth added a commit that referenced this issue Jan 21, 2017
@rnorth
Add utility class to allow image names to be configured via a classpa…
f15ebcc 
…th file

Replace static string names for ambassador and vnc recorder container images with classpath lookup.

Add note to readme re overriding hardcoded image names

Refs #259, #276
@rnorth rnorth mentioned this issue Jan 21, 2017
Merged
rnorth added a commit that referenced this issue Jan 21, 2017
@rnorth
Add utility class to allow image names to be configured via a classpa…
c412994 
…th file

Replace static string names for ambassador and vnc recorder container images with classpath lookup.

Add note to readme re overriding hardcoded image names

Refs #259, #276
rnorth added a commit that referenced this issue Jan 22, 2017
@rnorth
Add utility class to allow image names to be configured via a classpa…
c88ef71 
…th file

Replace static string names for ambassador and vnc recorder container images with classpath lookup.

Add note to readme re overriding hardcoded image names

Refs #259, #276
rnorth added a commit that referenced this issue Jan 22, 2017
@rnorth
Add utility class to allow image names to be configured via a classpa…
015a32c 
…th file

Replace static string names for ambassador and vnc recorder container images with classpath lookup.

Add note to readme re overriding hardcoded image names

Refs #259, #276
rnorth added a commit that referenced this issue Jan 22, 2017
@rnorth
Add utility class to allow image names to be configured via a classpa…
40ddc29 
…th file

Replace static string names for ambassador and vnc recorder container images with classpath lookup.

Add note to readme re overriding hardcoded image names

Refs #259, #276
@bsideup bsideup added this to the 1.1.9 milestone Jan 23, 2017
@rnorth rnorth modified the milestones: 1.1.9, 1.1.10 Feb 12, 2017
@bsideup bsideup modified the milestones: 1.1.10, 1.1.8 Mar 2, 2017
@bsideup
Copy link
Member

bsideup commented Mar 2, 2017

Seems to be fixed and released in 1.1.8

@bsideup bsideup closed this as completed Mar 2, 2017
@wu-sheng wu-sheng mentioned this issue Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.8
Development

No branches or pull requests
2 participants
@rnorth @bsideup