Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local Docker compose impossible on Windows #416

Closed
declension opened this issue Jul 25, 2017 · 4 comments
Closed

Local Docker compose impossible on Windows #416

declension opened this issue Jul 25, 2017 · 4 comments
Labels
type/bug

Comments

@declension
Copy link

declension commented Jul 25, 2017 •
edited
Loading

Hi

In 1.4.1, the implementation for the LocalDockerCompose class has a constant specifying the executable name of local Docker Compose.

This is hard-coded to docker-compose which is fine on *nix / OS X, but fails on Windows, which is expecting docker-compose.exe.

It might be nice if this auto-detected Windows and used the .exe version, or even just tried both in turn...
@bsideup
Copy link
Member

bsideup commented Jul 25, 2017

Hi @declension,

Thanks for reporting!

We already have an issue regarding .exe (Damn you, Windows! :D ) here: #62

But it's about docker-machine. Do you want to fix it yourself? Shouldn't be hard, and we're more than happy to receive PRs :)

@declension
Copy link
Author

Thanks @bsideup - I'll try to get some time whilst I still have a Windows machine available (one more day....).

Actually when building testcontainers current master on this same (Windows 10) machine I was getting several test failures, so may be more things to investigate / fix than I thought (related, perhaps).

@barrycommins
Copy link
Contributor

I managed to get this working by adding a copy of docker-compose to my path without the .exe extension.

Obviously a hack, but it seems to work

@barrycommins barrycommins mentioned this issue Aug 9, 2017
Merged
bsideup pushed a commit that referenced this issue Aug 11, 2017
@barrycommins @bsideup
Setting platform dependent docker-compose executable name (#437)
1a04781 
* Setting platform dependent docker-compose executable name

Fixes #416

* Changed docker-compose executable naming to be more concise

* Reverted Compose executable variable name, added change to CHANGELOG.md
@declension
Copy link
Author

Thanks!

@glebsts glebsts mentioned this issue Sep 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bsideup @declension @barrycommins