Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-Machine installation on Windows can't be found #62

Closed
MaXal opened this issue Feb 11, 2016 · 5 comments
Closed

Docker-Machine installation on Windows can't be found #62

MaXal opened this issue Feb 11, 2016 · 5 comments

Comments

@MaXal
Copy link

MaXal commented Feb 11, 2016

Due to the following check in DockerMachineClient:

public boolean isInstalled() {
        return executableExists("docker-machine");
}

docker installation on Windows can't be found. On Windows it's necessary to use "docker-machine.exe" instead of just "docker-machine".

For example, the following code:
Files.isExecutable(FileSystems.getDefault().getPath("C:\\Program Files\\Docker Toolbox\\docker-machine.exe"))
works but
Files.isExecutable(FileSystems.getDefault().getPath("C:\\Program Files\\Docker Toolbox\\docker-machine"))
doesn't.

@rnorth
Copy link
Member

rnorth commented Feb 11, 2016

Hi,
Sorry but I've not worked on Windows support yet - this ought to be noted in the docs, and sorry that you've found out the hard way.

Docker-Machine detection will be one issue; there may potentially be other minor ones too (the volume-based screen recording feature for the selenium module is one thing that springs to mind)

I'd be happy to integrate the changes necessary to make it work, though, but it may take some time for me to do this myself. I'll have a think about this...

Richard

rnorth added a commit that referenced this issue Feb 11, 2016
Add note re Linux/OS X being the only supported hosts at present (refs #62)
Add note re current need to use HTTP/HTTPS rather than unix sockets (refs #61)
@rnorth
Copy link
Member

rnorth commented Feb 13, 2016

Implementation of this needs to take #63 into account as well - there's some simplification possible.

@rnorth rnorth changed the title Docker installation on Windows can't be found Docker-Machine installation on Windows can't be found Feb 17, 2016
@rnorth rnorth mentioned this issue Mar 1, 2016
@rnorth
Copy link
Member

rnorth commented Mar 1, 2016

Raised #85 to track Windows support.

v-schulz added a commit to v-schulz/testcontainers-java that referenced this issue Mar 1, 2016
On Windows systems the extension is added to the command name of the
executable.

Fixing issue testcontainers#62 .
v-schulz added a commit to v-schulz/testcontainers-java that referenced this issue Apr 23, 2016
On Windows systems the extension is added to the command name of the
executable.

Fixing issue testcontainers#62 .
v-schulz added a commit to v-schulz/testcontainers-java that referenced this issue Apr 24, 2016
On Windows systems the extension is added to the command name of the
executable.

Fixing issue testcontainers#62 .
@rnorth
Copy link
Member

rnorth commented Apr 25, 2016

@MaXal just to let you know, we have Windows support as an alpha release now - please see docs here if you're interested: http://testcontainers.viewdocs.io/testcontainers-java/usage/windows_support/

@MaXal
Copy link
Author

MaXal commented Apr 25, 2016

@rnorth Thank you! I will definitely check it out.

@rnorth rnorth closed this as completed Jul 6, 2016
rnorth pushed a commit that referenced this issue Dec 23, 2018
Bumps [jaxb-api](https://github.com/javaee/jaxb-spec) from 2.3.0 to 2.3.1.
<details>
<summary>Commits</summary>

- [`7de2ca1`](javaee/jaxb-spec@7de2ca1) Preparing for release 2.3.1
- [`5cbac0c`](javaee/jaxb-spec@5cbac0c) Merge pull request [#62](https://github-redirect.dependabot.com/javaee/jaxb-spec/issues/62) from lukasj/fix
- [`c61c8df`](javaee/jaxb-spec@c61c8df) fix cp year
- [`bd6cdf6`](javaee/jaxb-spec@bd6cdf6) Revert "Removed usage of .internal package pointing to JavaSE."
- [`4d09bb1`](javaee/jaxb-spec@4d09bb1) allow running in OSGi on newer jdks
- [`e9625c8`](javaee/jaxb-spec@e9625c8) Preparing for development 2.3.2-SNAPSHOT
- [`9ef650f`](javaee/jaxb-spec@9ef650f) Preparing for release 2.3.1-RC1
- [`7acf248`](javaee/jaxb-spec@7acf248) Preparing for development 2.3.2-SNAPSHOT
- [`c44722d`](javaee/jaxb-spec@c44722d) Preparing for release 2.3.1-RC1
- [`f786240`](javaee/jaxb-spec@f786240) Preparing for development 2.3.2-SNAPSHOT
- Additional commits viewable in [compare view](javaee/jaxb-spec@2.3.0...2.3.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=javax.xml.bind:jaxb-api&package-manager=gradle&previous-version=2.3.0&new-version=2.3.1)](https://dependabot.com/compatibility-score.html?dependency-name=javax.xml.bind:jaxb-api&package-manager=gradle&previous-version=2.3.0&new-version=2.3.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants