Failing unit tests on Windows: Invalid Bind Mount Spec #84

x97mdr · 2016-03-01T11:19:10Z

(I know Windows support is not on the table right now, but thought I would note this exception here for others)

When running the unit tests on Windows (after patching for #62) I came across this problem. Looks like this is a relevant related issue: moby/moby#12751.

org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception

at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:83)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:107)
at org.testcontainers.containers.GenericContainer.starting(GenericContainer.java:423)
at org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:28)
at org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:31)
at org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:31)
at org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:31)
at org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:31)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:166)
at org.testcontainers.containers.GenericContainer.lambda$start$0(GenericContainer.java:110)
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:76)
... 26 more
Caused by: com.github.dockerjava.api.InternalServerErrorException: Invalid bind mount spec "/C:/dev/testcontainers-java/core/target/test-classes/mappable-resource/test-resource.txt:/content.txt:ro": volumeinvalid: Invalid volume specification: '/C:/dev/testcontainers-java/core/target/test-classes/mappable-resource/test-resource.txt:/content.txt:ro'

at com.github.dockerjava.jaxrs.filter.ResponseStatusExceptionFilter.filter(ResponseStatusExceptionFilter.java:53)
at org.glassfish.jersey.client.ClientFilteringStages$ResponseFilterStage.apply(ClientFilteringStages.java:134)
at org.glassfish.jersey.client.ClientFilteringStages$ResponseFilterStage.apply(ClientFilteringStages.java:123)
at org.glassfish.jersey.process.internal.Stages.process(Stages.java:171)
at org.glassfish.jersey.client.ClientRuntime.invoke(ClientRuntime.java:251)
at org.glassfish.jersey.client.JerseyInvocation$2.call(JerseyInvocation.java:683)
at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:424)
at org.glassfish.jersey.client.JerseyInvocation.invoke(JerseyInvocation.java:679)
at org.glassfish.jersey.client.JerseyInvocation$Builder.method(JerseyInvocation.java:435)
at org.glassfish.jersey.client.JerseyInvocation$Builder.post(JerseyInvocation.java:338)
at com.github.dockerjava.jaxrs.CreateContainerCmdExec.execute(CreateContainerCmdExec.java:32)
at com.github.dockerjava.jaxrs.CreateContainerCmdExec.execute(CreateContainerCmdExec.java:14)
at com.github.dockerjava.jaxrs.AbstrSyncDockerCmdExec.exec(AbstrSyncDockerCmdExec.java:23)
at com.github.dockerjava.core.command.AbstrDockerCmd.exec(AbstrDockerCmd.java:33)
at com.github.dockerjava.core.command.CreateContainerCmdImpl.exec(CreateContainerCmdImpl.java:142)
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:132)
... 28 more

rnorth · 2016-03-01T14:59:36Z

Thanks for raising this - good idea to get the Windows issues out in the open even while the support is sadly not there.

I've raised #85 to act as the main ticket for tracking Windows support.

The prior class PathOperations is renamed to PathUtils that now supports to convert a windows path into a MinGW compatible path. Furthermore, only some paths need to be converted. Thus a new method "addHostSystemAwareFileSystemBind" for GenericContainer is introduced that only transforms paths if run on a Windows system. Fixes issue testcontainers#84 .

x97mdr · 2016-03-02T11:38:57Z

No problem. If I get a chance I will help out with support.

On Tuesday, 1 March 2016, Richard North notifications@github.com wrote:

Thanks for raising this - good idea to get the Windows issues out in the
open even while the support is sadly not there.

I've raised #85
#85 to act
as the main ticket for tracking Windows support.

—
Reply to this email directly or view it on GitHub
#84 (comment)
.

mathiasconradt · 2016-03-17T12:50:46Z

Luckily I came across this ticket and it seems I am not the only one having problems with Docker and Windows. I have already reported this error message "Invalid bind mount spec" in context of Windows 2016 TP4 and Docker as well as Windows Containers: http://superuser.com/questions/1051520/docker-windows-container-how-to-mount-a-host-folder-as-data-volume-on-windows

bsideup · 2016-04-06T12:16:29Z

hey @v-schulz ,

How is Windows support going? I see some changes from you on it in your fork, will you send them back?

v-schulz · 2016-04-06T14:55:28Z

hi @bsideup ,

@rnorth and I are discussing the upcoming steps in the other thread about windows support. I think before I can merge the changes we need to resolve the CI issue. Atm there is no possibility to test the code on Windows. Another temporary possibility may be to ignore Windows-specific CI until it is possible.

bsideup · 2016-04-06T14:57:29Z

@v-schulz we started to use TestContainers on Windows today and discovered that it's not working (at all), so your changes (with some minor fixes) looks good even without CI at this moment, at least they will not break Windows support because there is no such :D

The prior class PathOperations is renamed to PathUtils that now supports to convert a windows path into a MinGW compatible path. Furthermore, only some paths need to be converted. Thus a new method "addHostSystemAwareFileSystemBind" for GenericContainer is introduced that only transforms paths if run on a Windows system. Fixes issue testcontainers#84 .

rnorth · 2016-04-25T06:10:52Z

@x97mdr @mathiasconradt just to let you know, we have Windows support as an alpha release now - please see docs here if you're interested: http://testcontainers.viewdocs.io/testcontainers-java/usage/windows_support/

x97mdr · 2016-04-26T01:19:52Z

Thanks Richard!

Will try it shortly

On Monday, 25 April 2016, Richard North notifications@github.com wrote:

@x97mdr https://github.com/x97mdr @mathiasconradt
https://github.com/mathiasconradt just to let you know, we have Windows
support as an alpha release now - please see docs here if you're
interested:
http://testcontainers.viewdocs.io/testcontainers-java/usage/windows_support/

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#84 (comment)

genuss · 2018-02-16T09:38:48Z

@bsideup Following up our discussion in pro.jvm I have the exact same issue as the topicstarter here.
So the error comes when testcontainers makes the startup checks and tries to mount C:\Users\user\AppData\Local\Temp\.testcontainers-tmp-6153256460751889885:/dummy:ro
Error from docker daemon is:

{"message":"invalid volume specification: 'C:\\Users\\user\\AppData\\Local\\Temp\\.testcontainers-tmp-6153256460751889885:/dummy:ro'"}

My setup is:
OS Windows 7 x64 7601.
docker-machine 0.7.0 with virtualbox driver.
docker client 17.09.0-ce
docker daemon 17.11.0-ce
testcontainers 1.6.0
However the exact version don't matter much here.

To work around this error testcontainers can check if there is a docker-machine environment and translate windows paths to boot2docker ones when mounting. This is possible because docker-machine mounts C:\Users to VM as /C/Users unless --virtualbox-no-share flag was specified while creating a machine.
So in this case path will be /C/Users/user/AppData/Local/Temp/.testcontainers-tmp-6153256460751889885.

In fact for now I don't actually need mounts now, so I just turned off the startup checks and everything else works like a charm, so it's not so critical for me. Moreover I hope soon I will move to windows 10 with normal docker-for-windows support.

bsideup · 2018-02-16T09:49:02Z

@genuss thanks for a report! 💪
I wonder if you want to contribute this small change yourself (since you have an environment to test it)? 🤓

genuss · 2018-02-16T13:33:32Z

OK, will try to do that. Could you help me with where to look for this path generator in source code?

bsideup · 2018-02-16T13:45:06Z

@genuss probably here:

testcontainers-java/core/src/main/java/org/testcontainers/utility/MountableFile.java

Line 189 in 2bd025b

result = PathUtils.createMinGWPath(result).substring(1);

trevorpgray · 2018-02-22T15:44:05Z

I've encountered the same issue as @genuss; however, disabling startup checks doesn't seem like a viable workaround. Am I missing something?

It seems like I still get the same error because the ryuk container attempts to mount the volume regardless of whether or not the checks are run:

testcontainers-java/core/src/main/java/org/testcontainers/utility/ResourceReaper.java

Lines 80 to 81 in 87e22ec

    
           // Not needed for Ryuk, but we perform pre-flight checks with it (micro optimization) 
        
           new Bind(mountableFile.getResolvedPath(), new Volume("/dummy"), AccessMode.ro)

testcontainers-java/core/src/main/java/org/testcontainers/DockerClientFactory.java

Lines 116 to 126 in 87e22ec

    
           String ryukContainerId = ResourceReaper.start(hostIpAddress, client); 
        
           log.info("Ryuk started - will monitor and terminate Testcontainers containers on JVM exit"); 
        
           VisibleAssertions.info("Checking the system..."); 
        
           checkDockerVersion(version.getVersion()); 
        
           if (!TestcontainersConfiguration.getInstance().isDisableChecks()) { 
        
               checkDiskSpace(client, ryukContainerId); 
        
               checkMountableFile(client, ryukContainerId); 
        
           }

genuss · 2018-02-22T20:38:05Z

@trevorpgray indeed that's true. For a workaround you can just downgrade to 1.5.1 version. There is no ryuk container there.

kiview · 2018-02-24T11:28:08Z

@trevorpgray Would you like to raise a seperate issue regarding Ryuk container in Docker-Toolbox (?) environments on Windows < 10? I'll try to setup a Windows 7 VM with Docker-Toolbox soon, to have at least a testing environment available.

rnorth mentioned this issue Mar 1, 2016

Windows support #85

Closed

rnorth added the client/docker-machine label Mar 20, 2016

rnorth closed this as completed Jul 6, 2016

trevorpgray mentioned this issue Mar 5, 2018

Ryuk container in Docker-Toolbox on Windows 7 #599

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Failing unit tests on Windows: Invalid Bind Mount Spec #84

Failing unit tests on Windows: Invalid Bind Mount Spec #84

x97mdr commented Mar 1, 2016

rnorth commented Mar 1, 2016

x97mdr commented Mar 2, 2016

mathiasconradt commented Mar 17, 2016

bsideup commented Apr 6, 2016

v-schulz commented Apr 6, 2016

bsideup commented Apr 6, 2016

rnorth commented Apr 25, 2016

x97mdr commented Apr 26, 2016

genuss commented Feb 16, 2018

bsideup commented Feb 16, 2018

genuss commented Feb 16, 2018

bsideup commented Feb 16, 2018

trevorpgray commented Feb 22, 2018

genuss commented Feb 22, 2018

kiview commented Feb 24, 2018

Failing unit tests on Windows: Invalid Bind Mount Spec #84

Failing unit tests on Windows: Invalid Bind Mount Spec #84

Comments

x97mdr commented Mar 1, 2016

rnorth commented Mar 1, 2016

x97mdr commented Mar 2, 2016

mathiasconradt commented Mar 17, 2016

bsideup commented Apr 6, 2016

v-schulz commented Apr 6, 2016

bsideup commented Apr 6, 2016

rnorth commented Apr 25, 2016

x97mdr commented Apr 26, 2016

genuss commented Feb 16, 2018

bsideup commented Feb 16, 2018

genuss commented Feb 16, 2018

bsideup commented Feb 16, 2018

trevorpgray commented Feb 22, 2018

genuss commented Feb 22, 2018

kiview commented Feb 24, 2018