VncRecordingContainer creates an unnecessary delay during video export

[nachg]

Steps to reproduce:

1. Run UI test with Selenium WebBrowser and video recording enabled, save the system time (t0)
2. In demo purposes It should be working 10sec or above
3. After test will be completed, save the system time (t1)
4. Start exporting the video into mp4 or flv
5. Save the system time after video export (t2)

Expected result:
Video should have length: t1-t0

Actual result:
Video length is (t2-t0)

[kiview]

Hey @nachg, thanks for your report. You say the video has a delay (delay in starting?), but from your description it sounds, like the video contains superfluous context after the test. Which is the case?

[nachg]

"after the test" is correct.
Here is an example:
https://stackoverflow.com/questions/71855139/video-recording-of-webdriver-session-with-testcontainers
My first commit to the: https://github.com/nachg/DockerDemo will show the problem and the second commit is fixing it.

[vmassol]

Hello, we're also seeing this on XWiki. We have a TC/Webdriver test that takes 30s to execute and the save of the video takes 11mn. When we check the resulting FLV file, its length is 11mn and not 30s.

It seems that the reencoding which takes 11mn doesn't stop the recording and thus it's still recording then the reencoding executes. BTW any idea why there's a need to reencode?

thanks