Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VncRecordingContainer creates an unnecessary delay during video export. #5269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nachg
Copy link

@nachg nachg commented Apr 14, 2022

No description provided.

@kiview
Copy link
Member

kiview commented Aug 8, 2022

Hey @nachg, can you please add a bit more context to the PR?

@nachg
Copy link
Author

nachg commented Aug 9, 2022

Hey @nachg, can you please add a bit more context to the PR?
I put context here:
#5268

@kiview
Copy link
Member

kiview commented Aug 9, 2022

Can you please elaborate on how copying the file before reencoding fixes the issue at hand?

@nachg
Copy link
Author

nachg commented Aug 9, 2022

Can you please elaborate on how copying the file before reencoding fixes the issue at hand?

VNC recorder working with the output file as with a stream. If we will start the encoding process on that file, it length will be increased during the process. That's why I create a copy - to "stop" extanding the file length by the VNC. Another possible solution is to stop the VNC process and run encoding after it. But I was not able to find the way how it can be done.

@deejgregor
Copy link
Contributor

Another possible solution is to stop the VNC process and run encoding after it. But I was not able to find the way how it can be done.

Here is how I've hacked it up: #6229

I plan to submit a PR to stop the recording after the test is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants