Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: no busy wait if Docker repository returns 5xx #6678

Closed
seregamorph opened this issue Feb 28, 2023 · 1 comment
Closed

[Enhancement]: no busy wait if Docker repository returns 5xx #6678

seregamorph opened this issue Feb 28, 2023 · 1 comment

Comments

@seregamorph
Copy link

Module

Core

Proposal

There is retry cycle in RemoteDockerImage.resolve in case if Docker repository responds 5xx code. This cycle has the limit on time execution, but once the situation can happen, the log is just fully of garbage messages of failed attempt to make an HTTP call. Also it makes the redundant load on a docker repo.
In our case it was a wrong configured Artifactory for Docker images, the authentication token was missing. In the log there were thousands of failure messages done while timeout did not happen.

The proposal is pretty simple: add the sleep between retries in this cycle - either constant or logarithmic.

@eddumelendez
Copy link
Member

This has been fixed in #8453, will be part of the next release.

@eddumelendez eddumelendez closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants