Solve #6678 (sleep in RemoteDockerImage retries) #6679
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #6678
There is retry cycle in
RemoteDockerImage.resolve
in case if Docker repository responds 5xx code. This cycle has the limit on time execution, but once the situation can happen, the log is just fully of garbage messages of failed attempt to make an HTTP call. Also it makes the redundant load on a docker repo.In our case it was a wrong configured Artifactory for Docker images, the authentication token was missing. In the log there were thousands of failure messages done while timeout did not happen.
The proposal is pretty simple: add the sleep between retries in this cycle - either constant or logarithmic.