-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate examples project to Gradle subproject #1177
Conversation
83a8abb
to
609ccfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependabot config needs to be updated as well
@kiview I would really recommend using |
I wasn't aware of |
b8ba484
to
dc4c6b5
Compare
@kiview Do you have a target date for getting this PR merged? Would love to contribute more examples. |
Also fix identation in singleton-container sources
f8220de
to
7dd3ccf
Compare
I'd be good to merge, let's have @bsideup a final look 🙂 |
} | ||
|
||
dependencies { | ||
compileOnly 'org.slf4j:slf4j-api:1.7.25' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it compileOnly
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was provided
in the Maven pom.xml.
Let's just remove this.
redis.start(); | ||
} | ||
public static final GenericContainer redis = new GenericContainer("redis:3.0.6") | ||
.withExposedPorts(6379); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it IntelliJ's formatting? o_O
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, or our .editorconfig
?
Co-Authored-By: kiview <kiview@users.noreply.github.com>
@bsideup Are we good to merge? |
@kiview yes 🚀 |
@bmuschko We just merged the PR, we'd love to get more examples if you have some good ideas 🙂 |
@kiview Nice, I will check it out in the coming days. |
I'm not touching the docs here, this was just for migrating the existing Maven example project.
Let's see if it works on CircleCI also...
I thought it would be cute to have a sub-subproject structure, like
:examples:spring-boot
.First I wanted to do it for our modules as well, but it would break the existing cross subproject dependencies, so I left it as is for modules.