New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example cucumber test #1180

Merged

bsideup merged 10 commits into testcontainers:master from stsefanenko:example-1139

Mar 9, 2019

Contributor

stsefanenko commented Jan 25, 2019

No description provided.

stsefanenko requested review from bsideup, kiview and rnorth as code owners

January 25, 2019 09:30

bsideup reviewed

View reviewed changes

examples/cucumber/pom.xml Outdated Show resolved Hide resolved

bsideup reviewed

View reviewed changes

examples/cucumber/src/test/java/org/testcontainsers/examples/Stepdefs.java Show resolved Hide resolved

bsideup reviewed

View reviewed changes

examples/cucumber/src/test/java/org/testcontainsers/examples/Stepdefs.java Outdated Show resolved Hide resolved

bsideup reviewed

View reviewed changes

examples/cucumber/src/test/java/org/testcontainsers/examples/Stepdefs.java Outdated Show resolved Hide resolved

bsideup reviewed

View reviewed changes

examples/pom.xml Outdated Show resolved Hide resolved

bsideup added the type/docs label

bsideup added this to the next milestone

testcontainers deleted a comment

testcontainers deleted a comment

testcontainers deleted a comment

testcontainers deleted a comment

testcontainers deleted a comment

bsideup removed this from the next milestone

Member

rnorth commented Feb 9, 2019

We'll need to update this once #1177 is merged, unfortunately.

Artem Stsefanenko added 7 commits

February 21, 2019 15:35


          cucumber example

92fa5c9


          remove spring boot dependency

346599b


           integrate with TestLifecycleAware interface and make it record video…

929aba6

… after a test failure


          fix parameter after review

a68cab4


          fixes after review

1b663cc


          move dependency to module

f6fc3f7


          update to gradle

f6985c0

stsefanenko force-pushed the example-1139 branch from b1445ff to f6985c0 Compare

February 21, 2019 12:53

Contributor Author

stsefanenko commented Feb 21, 2019

Updated to gradle

Member

bsideup commented Feb 21, 2019 •

edited

Loading

Thanks @stsefanenko! Sorry for a lack of attention on this one. It looks good, I will have a final look and merge after CI reports green status 👍

bsideup added this to the next milestone

bsideup reviewed

View reviewed changes

examples/cucumber/src/test/java/org/testcontainsers/examples/Stepdefs.java Outdated Show resolved Hide resolved


          Update examples/cucumber/src/test/java/org/testcontainsers/examples/S…

ac723f0

…tepdefs.java

Co-Authored-By: stsefanenko <stsefanenko@gmail.com>

stsefanenko and others added 2 commits

March 3, 2019 20:37


          Merge branch 'master' into example-1139

ff6b3cc


          Merge branch 'master' into example-1139

557c43d

bsideup merged commit 2033706 into testcontainers:master

Member

bsideup commented Mar 9, 2019

@stsefanenko merged! 🎉
Thanks a lot, good job! 👍

Member

rnorth commented Mar 12, 2019

Released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.10.7!

rnorth removed this from the next milestone

stsefanenko mentioned this pull request

Example needed: Cucumber tests #1139

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment