-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make default file recording directory of BrowserWebDriverContainer platform independent #2562
Conversation
…atform independent.
@@ -79,6 +82,14 @@ public BrowserWebDriverContainer() { | |||
.withStrategy(new HostPortWaitStrategy()) | |||
.withStartupTimeout(Duration.of(15, SECONDS)); | |||
|
|||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should move it to configure
and create the dir only if recording is enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the code.
/azp run "Windows 10 - Docker for Windows" |
No pipelines are associated with this pull request. |
/azp run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -52,6 +54,7 @@ | |||
private static final int VNC_PORT = 5900; | |||
|
|||
private static final String NO_PROXY_KEY = "no_proxy"; | |||
public static final String TC_TEMP_DIR_PREFIX = "tc"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, sorry.
/azp run Windows 10 - Docker for Windows |
Azure Pipelines successfully started running 1 pipeline(s). |
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 Thanks for the contribution! |
…atform independent (testcontainers#2562) Co-authored-by: Sergei Egorov <bsideup@gmail.com>
Fixes incompatibility of Windows with default recording directory, makes Windows work OOTB.
Not 100% sure how to best handle the
IOException
in the constructor.