-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regard specified VNC recording directory for BrowserWebDriverContainer again #2574
Regard specified VNC recording directory for BrowserWebDriverContainer again #2574
Conversation
modules/selenium/src/main/java/org/testcontainers/containers/BrowserWebDriverContainer.java
Outdated
Show resolved
Hide resolved
}, Optional.empty()); | ||
|
||
String[] files = vncRecordingDirectory.list(new PatternFilenameFilter("PASSED-" + testName + "-.*\\.flv")); | ||
assertTrue("Recorded file not found", files.length == 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent addition to the test, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after @bsideup's proposed code style change.
...s/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java
Outdated
Show resolved
Hide resolved
Hi @srempfer, Good catch! Sorry for letting it through. We thought this part is tested (it should be!) and did not bother double checking 😅 Extra points for adding a test - now it is tested :D |
5f90aca
to
0810dab
Compare
…r again (testcontainers#2574) Co-authored-by: Stefan Rempfer <srempfer@rt.ipnt.de>
Since the changes of #2562 which were released with 1.14.0 the possibility to specify a target directory for the VNC recordings doesn't work anymore.