Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch browser containers to use LogMessageWaitStrategy #328

Merged
merged 3 commits into from
May 1, 2017
Merged

Switch browser containers to use LogMessageWaitStrategy #328

merged 3 commits into from
May 1, 2017

Commits on Apr 30, 2017

  1. Resolve #326, making browser container startup timeout configurable. 

    Reduces default browser container startup timeout to 15s, down from an
unnecessarily high 120s.

This also replaces inheritance-based `waitUntilContainerStarted` with
composition-based `WaitStrategy`. The new `LogMessageWaitStrategy` allows
us to wait based upon the Selenium container log output, rather than the
 relatively expensive process of repeatedly trying to create and connect
 a `RemoteWebDriver` instance.
    @rnorth
    rnorth committed Apr 30, 2017
    Configuration menu
    Copy the full SHA
    47f1959 View commit details
    Browse the repository at this point in the history

  2. Resolve shading-related inheritance issues with BrowserWebDriverConta… 

    …iner

This change makes docker-java NO LONGER SHADED into testcontainers core JAR
    @rnorth
    rnorth committed Apr 30, 2017
    Configuration menu
    Copy the full SHA
    c962b0f View commit details
    Browse the repository at this point in the history

  3. Trim WaitingConsumer output frame text to eliminate double-newline ef… 

    …fect
    @rnorth
    rnorth committed Apr 30, 2017
    Configuration menu
    Copy the full SHA
    2754c28 View commit details
    Browse the repository at this point in the history