[LocalStack] Deprecate methods using aws sdk v1 #5489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
LocalStackContainer
depends on aws sdk v1. We have receivedfeedback about moving to aws sdk v2. However, we think that the
class already provides the enough information to be used such as
getEndpointOverride()
,getRegion()
,getAccessKey()
andgetSecretKey
.So, we are deprecating
getDefaultCredentialsProvider()
andgetEndpointConfiguration
which are going to be removed in the feature and
LocalStack
module willnot depend on any aws sdk.