Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated methods and undeclared transitive dependency to AWS SDK v1 #5827

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Removed deprecated methods and undeclared transitive dependency to AWS SDK v1 #5827

merged 3 commits into from
Feb 16, 2023

Conversation

AB-xdev
Copy link
Contributor

@AB-xdev AB-xdev commented Sep 6, 2022

Fixes #4279.

The problem:
The localstack module has an undeclared dependency to parts of the AWS SDK v1 which causes the above issue.

While the methods have been deprecated with #5489, this still doesn't fix the class loading problems.

The fix:
The removal of the deprecated methods, corresponding imports and dependencies should fix the class loading problems.

@AB-xdev AB-xdev requested a review from a team as a code owner September 6, 2022 14:52
@eddumelendez eddumelendez added this to the 2.0 milestone Sep 6, 2022
@eddumelendez
Copy link
Member

thanks for the PR @AB-xdev ! We are not planning to remove it for now but for 2.0.

@eddumelendez eddumelendez added the type/breaking-api-change Public APIs are being changed label Feb 16, 2023
@eddumelendez eddumelendez merged commit 1f34c51 into testcontainers:main Feb 16, 2023
@eddumelendez
Copy link
Member

Thanks for your contribution, @AB-xdev ! This is now merged in main and it will be part of the next release.

@AB-xdev AB-xdev deleted the fix-4279-noclassdef branch February 17, 2023 06:55
@kkocel
Copy link
Contributor

kkocel commented Mar 17, 2023

@eddumelendez do you know when it will be released? I use AWS SDK v2 and I would like not to have import v1.

@asafch
Copy link

asafch commented Jul 4, 2023

Hi @eddumelendez I couldn't find any mention in this repo of following semver or any other versioning policy, can you please direct me to it? I'm asking because this PR was merged as part of the 1.18.0 release, and the removal of the deprecated methods is a breaking change. Just want to understand how I should interpret the release notes when considering upgrading a specific module version in my projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.NoClassDefFoundError: com/amazonaws/auth/AWSCredentials with localstack module and AWS SDK2
4 participants