Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnixDomainSocketInitializer uses configured docker host in connect() #855

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

aantoniadisatypon
Copy link
Contributor

@aantoniadisatypon aantoniadisatypon commented Sep 4, 2018

As described in this comment UnixDomainSocketInitializer is using a default value for the socketPath instead of the one configured.

@bsideup bsideup merged commit 0901ddf into testcontainers:master Sep 5, 2018
@bsideup
Copy link
Member

bsideup commented Sep 5, 2018

@aantoniadisatypon merged, thanks!
FYI next release will use OkHttp transport by default, but your change is still helpful for the ones who want to switch back to Netty :)

@aantoniadisatypon
Copy link
Contributor Author

aantoniadisatypon commented Sep 5, 2018

@bsideup thank you! are there any plans regarding the release date?

@bsideup bsideup added this to the next milestone Sep 6, 2018
@bsideup
Copy link
Member

bsideup commented Sep 6, 2018

@aantoniadisatypon yes :) There will be RC1 later this week

@rnorth
Copy link
Member

rnorth commented Sep 10, 2018

We have this out in a Release Candidate build (1.9.0-rc1) for anyone who is keen to try it!

Release notes

@aantoniadisatypon
Copy link
Contributor Author

@bsideup It turns out that now we need to change ResourceReaper class as well to get the dockerHostPath from the dockerConfig, since it uses a hardcoded value for the socket and it fails to start if we use a different value for docker host. See PR #862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants