-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResourceReaper binding uses dockerConfigHostPath instead of default value #862
ResourceReaper binding uses dockerConfigHostPath instead of default value #862
Conversation
We might need to pass ENV variables to ryukContainer as well so that this container will can use the overridden DOCKER_HOST |
@aantoniadisatypon Sorry that the PR was pending so long. LGTM, but can you please rebase? |
Regarding Ryuk, you are right, but I think the code already handles this: |
@kiview there are some implications, plz don't merge, I'll try to explain tonight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocker
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case. |
This issue is now bothering me . |
No description provided.