Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceReaper binding uses dockerConfigHostPath instead of default value #862

Conversation

aantoniadisatypon
Copy link
Contributor

No description provided.

@aantoniadisatypon
Copy link
Contributor Author

We might need to pass ENV variables to ryukContainer as well so that this container will can use the overridden DOCKER_HOST

@kiview
Copy link
Member

kiview commented Oct 1, 2018

@aantoniadisatypon Sorry that the PR was pending so long. LGTM, but can you please rebase?

@kiview
Copy link
Member

kiview commented Oct 1, 2018

Regarding Ryuk, you are right, but I think the code already handles this:
https://github.com/testcontainers/moby-ryuk/blob/master/main.go#L25

@bsideup
Copy link
Member

bsideup commented Oct 1, 2018

@kiview there are some implications, plz don't merge, I'll try to explain tonight

Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocker

@stale
Copy link

stale bot commented Dec 30, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Dec 30, 2018
@stale
Copy link

stale bot commented Jan 13, 2019

This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case.

@stale stale bot closed this Jan 13, 2019
@kmehltretter
Copy link

This issue is now bothering me .
I tried running testcontainers with "rootless docker", but Reaper ryuk is not connecting to the correct unix domain socket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants