Skip to content

Commit

Permalink
fix: Add missing jest-dom prefix to config (fixes #10) (#13)
Browse files Browse the repository at this point in the history
* Revert "Revert "Autogenerate recommended config""

This reverts commit 0512ce6.

* Add missing jest-dom prefix to config (fixes #10)
  • Loading branch information
nickserv authored and benmonro committed Nov 6, 2019
1 parent 408badb commit ec23b96
Show file tree
Hide file tree
Showing 5 changed files with 64 additions and 14 deletions.
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,7 @@ Then configure the rules you want to use under the rules section.

```json
{
"rules": {
"jest-dom/prefer-checked": "error",
"jest-dom/prefer-enabled-disabled": "error",
"jest-dom/prefer-required": "error"
}
"rules": {}
}
```

Expand Down
16 changes: 11 additions & 5 deletions lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,19 @@ let requireIndex = require('requireindex');
// import all rules in lib/rules
module.exports.rules = requireIndex(__dirname + '/rules');

module.exports.generateRecommendedConfig = rules => {
return Object.entries(rules).reduce(
(memo, [name, rule]) =>
rule.meta.docs.recommended
? { ...memo, [`jest-dom/${name}`]: 'error' }
: memo,
{}
);
};

module.exports.configs = {
recommended: {
plugins: ['jest-dom'],
rules: {
'jest-dom/prefer-checked': 'error',
'jest-dom/prefer-enabled-disabled': 'error',
'jest-dom/prefer-required': 'error',
},
rules: module.exports.generateRecommendedConfig(module.exports.rules),
},
};
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"generate-readme-table": "node build/generate-readme-table.js"
},
"dependencies": {
"requireindex": "~1.1.0"
"requireindex": "~1.2.0"
},
"devDependencies": {
"eslint": "^6.6.0",
Expand All @@ -30,4 +30,4 @@
"node": ">=0.10.0"
},
"license": "ISC"
}
}
41 changes: 40 additions & 1 deletion tests/__snapshots__/index.test.js.snap
Original file line number Diff line number Diff line change
@@ -1,3 +1,42 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`should have all the rules 1`] = `Object {}`;
exports[`should have all the rules 1`] = `
Object {
"prefer-checked": Object {
"create": [Function],
"meta": Object {
"docs": Object {
"category": "jest-dom",
"description": "prefer toBeChecked over checking attributes",
"recommended": true,
"url": "prefer-checked",
},
"fixable": "code",
},
},
"prefer-enabled-disabled": Object {
"create": [Function],
"meta": Object {
"docs": Object {
"category": "jest-dom",
"description": "prefer toBeDisabled or toBeEnabled over checking attributes",
"recommended": true,
"url": "prefer-enabled-disabled",
},
"fixable": "code",
},
},
"prefer-required": Object {
"create": [Function],
"meta": Object {
"docs": Object {
"category": "jest-dom",
"description": "prefer toBeRequired over checking properties",
"recommended": true,
"url": "prefer-required",
},
"fixable": "code",
},
},
}
`;
11 changes: 10 additions & 1 deletion tests/index.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
const { rules } = require('../lib/index');
const { rules, generateRecommendedConfig, configs } = require('../lib/index');

it('should have all the rules', () => {
expect(rules).toMatchSnapshot();
});

it('should have a recommended config with recommended rules', () => {
expect(
generateRecommendedConfig({
good: { meta: { docs: { recommended: true } } },
bad: { meta: { docs: { recommended: false } } },
})
).toEqual({ 'jest-dom/good': 'error' });
});

0 comments on commit ec23b96

Please sign in to comment.