Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jit(arm64): support for and, or, and xor #225

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

summerwind
Copy link
Contributor

@summerwind summerwind commented Feb 11, 2022

Hello, The JIT support for Arm64 is really nice!
This PR adds support of and, or, and xor instruction for Arm64 JIT.
This might be a part of #187.

I have implemented this with reference to the x86 JIT code.
If you have any concerns about this, I would appreciate your review comments!

@summerwind summerwind force-pushed the arm64-jit-and-or-xor-support branch from 4466ade to 59f6304 Compare February 11, 2022 14:03
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for this, one small fix and then good to go!

wasm/jit/jit_arm64.go Show resolved Hide resolved
@summerwind summerwind force-pushed the arm64-jit-and-or-xor-support branch from 04d6606 to eef4faa Compare February 12, 2022 00:54
@summerwind summerwind requested a review from mathetake February 12, 2022 00:56
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mathetake mathetake merged commit 975bd6b into tetratelabs:main Feb 12, 2022
@mathetake
Copy link
Member

Thank you for your contribution (again)! 👯

@summerwind
Copy link
Contributor Author

Thank you!

@summerwind summerwind deleted the arm64-jit-and-or-xor-support branch February 12, 2022 01:01
@codefromthecrypt
Copy link
Contributor

it is exciting and motivating to see you again @summerwind 🙇

r8d8 pushed a commit to r8d8/wazero that referenced this pull request Feb 14, 2022
Signed-off-by: r8d8 <ckryvomaz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants