Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[precise-volume] fix arrows shortcuts active in search box #1002

Merged
merged 1 commit into from
Feb 8, 2023
Merged

[precise-volume] fix arrows shortcuts active in search box #1002

merged 1 commit into from
Feb 8, 2023

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Jan 23, 2023 •
edited
Loading

fix #875 fix #897 close #284

@Araxeus Araxeus changed the title fix precise-volume+searchbox interaction [precise-volume] fix arrows shortcuts active in search box Jan 23, 2023
@Araxeus
Copy link
Collaborator Author

Araxeus commented Jan 30, 2023 •
edited
Loading

Yikes I just realized that the PiP hotkey also trigger in the search box...

@th-ch
Copy link
Owner

th-ch commented Feb 8, 2023

Fix looks good, merging ✅
About the PiP hotkey, we can do a follow up PR!

@th-ch th-ch merged commit 70c55ca into th-ch:master Feb 8, 2023
@Araxeus
Copy link
Collaborator Author

Araxeus commented Feb 9, 2023

About the PiP hotkey, we can do a follow up PR!

It's actually much more annoying there, since the shortcut is registered on back.js

youtube-music/plugins/picture-in-picture/back.js

Line 107 in 70c55ca

electronLocalshortcut.register(win, options.hotkey, togglePiP);

Could probably add a front ipcRenderer handler that responds if the search box is open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Araxeus @th-ch