Implementing check to identify CMK errors (s3) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
IsKeyAccessDeniedErr
branch
from
dbff2d5 to
5ba7eb9
Compare
|
@GiedriusS @fpetkovski Thoughts? I wanna use to identify when the key access was revoked so we can return an well defined error from store gateway: on cortex: cortexproject/cortex#5420 |
fpetkovski
reviewed
Jun 28, 2023
| @@ -85,6 +85,9 @@ type BucketReader interface { | |||
| // IsObjNotFoundErr returns true if error means that object is not found. Relevant to Get operations. | |||
| IsObjNotFoundErr(err error) bool | |||
|
|
|||
| // IsCustomerManagedKeyError returns true if the permissions for key used to encrypt the object was revoked. | |||
| IsCustomerManagedKeyError(err error) bool | |||
There was a problem hiding this comment.
Could we return a newly defined ErrInvalidCustomerManagedKey error and use errors.Cause to identify it? This way a client does not need an instance of the bucket in order to distinguish between error types.
There was a problem hiding this comment.
I missed that we already have IsObjNotFoundErr, so I guess this should also be fine.
fpetkovski
approved these changes
Jun 28, 2023
| @@ -85,6 +85,9 @@ type BucketReader interface { | |||
| // IsObjNotFoundErr returns true if error means that object is not found. Relevant to Get operations. | |||
| IsObjNotFoundErr(err error) bool | |||
|
|
|||
| // IsCustomerManagedKeyError returns true if the permissions for key used to encrypt the object was revoked. | |||
| IsCustomerManagedKeyError(err error) bool | |||
There was a problem hiding this comment.
I missed that we already have IsObjNotFoundErr, so I guess this should also be fine.
yeya24
reviewed
Jun 29, 2023
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
IsKeyAccessDeniedErr
branch
from
f2d012e to
ebaa3e6
Compare
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bucket like s3 and Azure implementations allows encrypting the block storage with customer managed keys and the permissions to this keys can be revoked anytime.
This PR is creating a extra method (
IsCustomerManagedKeyError) when the key permission got revoked by the key owner and so the upstream can handle it appropriately (cortex,thanos)Related to: cortexproject/cortex#5420
As a first step only the s3 implementation is identifying such errors but i can follow up with the azure one.
Changes
IsCustomerManagedKeyErrormethod on the bucket interface.IsCustomerManagedKeyErroron the s3 bucket implementation.