-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement end-to-end ruler test for AlertManager HTTP Client. #4056
Comments
E2E tests for ruler are currently marked as skip. This re-enables the test until it breaks again and we are able to catch the flakiness. Also, it removes the test for AlertManager HTTP client pending when we can improve on implementation (see thanos-io#4056). Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
E2E tests for ruler are currently marked as skip. This re-enables the test until it breaks again and we are able to catch the flakiness. Also, it removes the test for AlertManager HTTP client pending when we can improve on implementation (see thanos-io#4056). Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
E2E tests for ruler are currently marked as skip. This re-enables the test until it breaks again and we are able to catch the flakiness. Also, it removes the test for AlertManager HTTP client pending when we can improve on implementation (see thanos-io#4056). Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
E2E tests for ruler are currently marked as skip. This re-enables the test until it breaks again and we are able to catch the flakiness. Also, it removes the test for AlertManager HTTP client pending when we can improve on implementation (see thanos-io#4056). Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
* Re-enable e2e test for ruler E2E tests for ruler are currently marked as skip. This re-enables the test until it breaks again and we are able to catch the flakiness. Also, it removes the test for AlertManager HTTP client pending when we can improve on implementation (see #4056). Signed-off-by: Michael Okoko <okokomichaels@outlook.com> * Bump rule group intervals and AM timeout Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Still valid. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
We need to test that Thanos Ruler is able to send alerts to AlertManager(AM) in different setups such as:
Because AlertManager supports HTTP only and no authentication, we had to initially use a mocked AM server instead of a “real” one:
thanos/test/e2e/rule_test.go
Line 237 in 98e369d
That didn’t work though, because having docker containers reach out to services running on the host would be hacky.
It will make sense to have a test implementation that will cater to those different setups, without the downsides of the initial implementation.
Possible solutions include putting the mocked server in a container, or putting AlertManager and a proxy in a container so services can reach them.
The text was updated successfully, but these errors were encountered: