Re-enable e2e test for ruler #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
previously approved these changes
Apr 15, 2021
|
Hi @idoqo, can you please rebase on main branch to fix CI? |
Sure! Also, Bartek has some suggestions at #4250 (comment) that we're looking to try out regarding the flaky tests. |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
idoqo
force-pushed
the
enable-ruler-e2e-test
branch
from
9db84b4
to
7cfd289
Compare
yeya24
reviewed
Jun 2, 2021
idoqo
force-pushed
the
enable-ruler-e2e-test
branch
from
7cfd289
to
ec9b042
Compare
E2E tests for ruler are currently marked as skip. This re-enables the test until it breaks again and we are able to catch the flakiness. Also, it removes the test for AlertManager HTTP client pending when we can improve on implementation (see thanos-io#4056). Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
Signed-off-by: Michael Okoko <okokomichaels@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2E tests for ruler are currently marked as skip because they're flaky. This re-enables the test with an attempt at fixing the flakiness (increasing the rule evaluation intervals so they don't oversaturate CI CPUs).
Also, it removes the test for AlertManager HTTP client pending when we can improve on implementation
(see #4056).
Signed-off-by: Michael Okoko okokomichaels@outlook.com
Changes