Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis integration support TLSConfig #5310

Closed
alileza opened this issue Apr 28, 2022 · 3 comments · Fixed by #5674
Closed

Redis integration support TLSConfig #5310

alileza opened this issue Apr 28, 2022 · 3 comments · Fixed by #5674
Labels
component: store

Comments

@alileza
Copy link

alileza commented Apr 28, 2022

Is your proposal related to a problem?

Support TLS for redis integration

Describe the solution you'd like

Add new Redis Client Config for tls enabled, and add TLSConfig here

Additional context

If I understand correctly currently there's no way we can connect to redis with TLS enabled
@alileza alileza mentioned this issue Apr 28, 2022
Closed
2 tasks
@pharaujo
Copy link
Contributor

I was trying out Redis support in query-frontend using AWS ElastiCache with "encryption in transit" enabled and also ran into this problem.

@stale
Copy link

stale bot commented Jul 31, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jul 31, 2022
@pharaujo
Copy link
Contributor

pharaujo commented Aug 2, 2022

I believe this is still needed

@stale stale bot removed the stale label Aug 2, 2022
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 5, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
82ef05c 
…loses issue thanos-io#5310
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 5, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
cc87a8b 
…loses issue thanos-io#5310
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 5, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
72e9bac 
…loses issue thanos-io#5310
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 14, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
b40c92d 
…loses issue thanos-io#5310
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 15, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
57a2332 
…loses issue thanos-io#5310
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 15, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
75f3d2a 
…loses issue thanos-io#5310
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 15, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
e7a20be 
…loses issue thanos-io#5310

Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 15, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
9d3714a 
…loses issue thanos-io#5310

Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>
@dbut023 dbut023 mentioned this issue Sep 16, 2022
Merged
2 tasks
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 22, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
6fcde9a 
…loses issue thanos-io#5310

Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 26, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
c37bb8d 
…loses issue thanos-io#5310

Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 27, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
329342f 
…loses issue thanos-io#5310

Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>
dbut023 added a commit to dbut023/thanos that referenced this issue Sep 27, 2022
@dbut023
Updated TLS support to the redis client based on PR thanos-io#5312. C…
1ff6a02 
…loses issue thanos-io#5310

Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>
matej-g pushed a commit that referenced this issue Sep 28, 2022
@dbut023
query frontend, store: Add TLS support to redis_client (#5674)
a4ea07f 
* Updated TLS support to the redis client based on PR #5312. Closes issue #5310

Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>

* Changelog

Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>

* documentation

Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>

Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: store
Projects
None yet
Milestone
No milestone
3 participants
@pharaujo @alileza @hanjm