-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in .json file name #6051
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Jan 18, 2023
fpetkovski
previously approved these changes
Jan 18, 2023
@sshantel we will need you to sign the DCO. You can do it with
followed by a force push. |
@fpetkovski Thanks, done! I missed that part here :) |
Oops sorry @sshantel. I merged this with main but seems it hit the DCO issue again. Would you mind rebasing main locally and force push? Then we should be good to merge, thanks! |
* compact: remove cancel on SyncMetas errors (thanos-io#5923) in a favour of 86b4039 SyncMetas will retry if it's retriable. Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated, the ones not and are not retriable will throw an interrupt to run.Group() by returning err and Group will call cancel() as it's configured for its interrupt func. Signed-off-by: Seena Fallah <seenafallah@gmail.com> Signed-off-by: Seena Fallah <seenafallah@gmail.com> * Cut v0.30.0-rc.0 (thanos-io#5992) * Cut v0.30.0-rc.0 Signed-off-by: bwplotka <bwplotka@gmail.com> * mdox fix. Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Cut 0.30.0 (thanos-io#6011) Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * *: cut 0.30.1 (thanos-io#6017) * fix duplicate metrics registration in redis client (thanos-io#6009) * fix duplicate metrics registration in redis client Signed-off-by: Kama Huang <kamatogo13@gmail.com> * fixed test Signed-off-by: Kama Huang <kamatogo13@gmail.com> Signed-off-by: Kama Huang <kamatogo13@gmail.com> * *: cut 0.30.1 Add CHANGELOG entry. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Kama Huang <kamatogo13@gmail.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Co-authored-by: Kama Huang <121007071+kama910@users.noreply.github.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * Tracing: Fix sampler defaults (thanos-io#5887) * Fix sampler defaults Signed-off-by: Matej Gera <matejgera@gmail.com> * Add CHANGELOG Signed-off-by: Matej Gera <matejgera@gmail.com> * Replace checkout with git-shallow-clone (thanos-io#5829) Signed-off-by: Matej Gera <matejgera@gmail.com> Signed-off-by: Matej Gera <matejgera@gmail.com> Signed-off-by: Matej Gera <matejgera@gmail.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * CHANGELOG: fix Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Seena Fallah <seenafallah@gmail.com> Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Kama Huang <kamatogo13@gmail.com> Signed-off-by: Matej Gera <matejgera@gmail.com> Co-authored-by: Seena Fallah <seenafallah@gmail.com> Co-authored-by: Kama Huang <121007071+kama910@users.noreply.github.com>
* Use e2edb.NewMinio to disable SSE Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Use temp fork for TLS Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Fix broken rules api fanout test Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Fix broken query compatibility test Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Remove fork Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Allow disabling max concurrency limit by setting limit to <= 0. Previously it was impossible to disable this limit. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Co-authored-by: Matej Gera <38492574+matej-g@users.noreply.github.com>
This PR changes the Thanos mixin dashboard widgets that are using the rate function from $interval magic variable to __rate_interval. It has been added in Grafana 7.2 for that exact purpose. Signed-off-by: Daniel Mellado <dmellado@redhat.com> Signed-off-by: Daniel Mellado <dmellado@redhat.com>
This commit extends the distributed execution proposal with an option to run distributed queries against a pool of Thanos Receivers. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
* fixed panic because of nil sampler Signed-off-by: Vasiliy Rumyantsev <4119114+xBazilio@users.noreply.github.com> * added CHANGELOG entry Signed-off-by: Vasiliy Rumyantsev <4119114+xBazilio@users.noreply.github.com> Signed-off-by: Vasiliy Rumyantsev <4119114+xBazilio@users.noreply.github.com>
* Fix Receiver panic when querying uninitialized TSDBs Receivers currently panic when retrieving labels for a TSDB that is being initialized. The reason for this is that the tenant is added to the tenants map and the TSDB is started in the background. When retrieving labels, the MultiTSDB creates Clients for each TSDB, even if a TSDB is not yet ready. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add CHANGELOG Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Gracefully terminate test Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
* Added native histogram support for sidecar, query, receiver. Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Added comment Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Cleanup native histogram tests Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Made native hist test ha and replace usage of at with att Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Fix deduplication with native histograms Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Enabled native histogram writing Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Committed missing files for write Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Added benchmark for histogram writing Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Fixed chunkSeriesIterator Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Enabled replication for native histogram write test Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Lint native histogram test imports Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Removed ToDo comments Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Cleanup Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Renamed lastValue of dedup iter and added TODO Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Fixed typo Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Added hidden native histogram flag for receive tsdb Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * merge Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Comments and reverted change to qfe Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Go mod tidy Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> * Dedup iter nit Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
This commit updates the Thanos PromQL engine to the latest version. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
* Receive external labels proposal Signed-off-by: haanhvu <haanh6594@gmail.com> * Restructure and edit proposal's content Signed-off-by: haanhvu <haanh6594@gmail.com> * Update proposal Signed-off-by: haanhvu <haanh6594@gmail.com> * Fix doc error Signed-off-by: haanhvu <haanh6594@gmail.com> Signed-off-by: haanhvu <haanh6594@gmail.com>
Signed-off-by: Ben Ye <benye@amazon.com> Signed-off-by: Ben Ye <benye@amazon.com>
* Fix stores filtering resets on reload `g0.store_matches` parameter appears in the url but doesn't applies in the frontend. Looks like it has been done on purpose and by removing a small piece of code fixes this issue. variable named `debugMode` is used for the store filtering checkbox which is an unappropriate name. Using `enableStoreFiltering` variable to represent the state of checkbox. Signed-off-by: Pradyumna Krishna <git@onpy.in> * Regenerate bindata.go Signed-off-by: Pradyumna Krishna <git@onpy.in> Signed-off-by: Pradyumna Krishna <git@onpy.in>
new PR here due to merge conflicts: #6087 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chantel Yip 52993239+sshantel@users.noreply.github.com
Changes
Verification