-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Update Prometheus #7416
Conversation
3c55ace
to
6c34cfa
Compare
@alanprot OK I just checked and I think the E2E test failure is related. The test tries to spin up a Prometheus locally using Prometheus binary. I logged the command in my local path.
And it failed with error below.
The config is:
I think what we can do is, rather than using global config to write the Prometheus config file here, we can write with plain yaml similar to this |
Let's update Prometheus version to prometheus/prometheus#14216 and see if it fixes it? |
Will do.. but i think there is another braking change that we will need to PR on prometheus.. I will push the change with the new prometheus for now but the build will fail. prometheus/common#538 (comment) I pinned the common to work around this issue. |
018be5d
to
f4ca9bc
Compare
Seems related to: prometheus/prometheus#13993 =/ |
472b5d7
to
bf38079
Compare
Ok.. We are not using I'm changing thanos to use |
bc1338a
to
15f804e
Compare
e930f77
to
2ea9fbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@GiedriusS @fpetkovski Can you guys take a peek on this one? |
We are seeing problems with grpc 1.64.0: grpc/grpc-go#7314. The issue in Thanos happens when we try to close stale connections here: https://github.com/thanos-io/thanos/blob/main/pkg/query/endpointset.go#L442. Maybe it's better to pin grpc to 1.63.2? |
Ok.. lemme do this. |
20bd25f
to
a1e9a67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Merge on green
2fe6d8a
to
e1f54b6
Compare
4ce18f0
to
e674b2a
Compare
Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: alanprot <alanprot@gmail.com>
…now support this use case Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: alanprot <alanprot@gmail.com>
e674b2a
to
02d1814
Compare
Signed-off-by: alanprot <alanprot@gmail.com>
Head branch was pushed to by a user without write access
02d1814
to
d45eac6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Uupdate Prometheus Signed-off-by: alanprot <alanprot@gmail.com> * Updating prometheus to 4e664035e84e Signed-off-by: alanprot <alanprot@gmail.com> * Temporarily pinning prometheus common Signed-off-by: alanprot <alanprot@gmail.com> * fixing lint Signed-off-by: alanprot <alanprot@gmail.com> * Using jsoniter to encode promql responses Signed-off-by: alanprot <alanprot@gmail.com> * Removing e2e test case with unvalid hifen on a matcher -> prometheus now support this use case Signed-off-by: alanprot <alanprot@gmail.com> * Updating prometheus to v0.52.2-0.20240606174736-edd558884b24 Signed-off-by: alanprot <alanprot@gmail.com> * pinning grpc to v1.63.2 Signed-off-by: alanprot <alanprot@gmail.com> --------- Signed-off-by: alanprot <alanprot@gmail.com> Co-authored-by: EC2 Default User <ec2-user@ip-172-31-21-10.us-west-2.compute.internal>
* Uupdate Prometheus Signed-off-by: alanprot <alanprot@gmail.com> * Updating prometheus to 4e664035e84e Signed-off-by: alanprot <alanprot@gmail.com> * Temporarily pinning prometheus common Signed-off-by: alanprot <alanprot@gmail.com> * fixing lint Signed-off-by: alanprot <alanprot@gmail.com> * Using jsoniter to encode promql responses Signed-off-by: alanprot <alanprot@gmail.com> * Removing e2e test case with unvalid hifen on a matcher -> prometheus now support this use case Signed-off-by: alanprot <alanprot@gmail.com> * Updating prometheus to v0.52.2-0.20240606174736-edd558884b24 Signed-off-by: alanprot <alanprot@gmail.com> * pinning grpc to v1.63.2 Signed-off-by: alanprot <alanprot@gmail.com> --------- Signed-off-by: alanprot <alanprot@gmail.com> Co-authored-by: EC2 Default User <ec2-user@ip-172-31-21-10.us-west-2.compute.internal>
Changes
We pinned
github.com/sercand/kuberesolver/v4 => github.com/sercand/kuberesolver/v5 v5.1.1
in order to be able to updategoogle.golang.org/grpc
needed byopentelemetry-go
(and consequently removed the replace forgoogle.golang.org/grpc
)Breaking Changes on Prometheus
chunkenc.Chunk
added aReset
method that needed to be implemented by the structs on thanos.jsoniter
due:Verification
Breaking Changes on the new go-grpc:
FailOnNonTempDialError
,WithBlock
, andWithReturnConnectionError
are three DialOptions that are only supported by Dial because they only affect the behavior of Dial itself. WithBlock causes Dial to wait until the ClientConn reports its State as connectivity.Connected. The other two deal with returning connection errors before the timeout (WithTimeout or on the context when using DialContext).