Use common interface to fetch secrets in HTTP client config #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpiritXIII
force-pushed
the
http-secret-interface
branch
2 times, most recently
from
0d08b50
to
95e1bd7
Compare
TheSpiritXIII
force-pushed
the
http-secret-interface
branch
2 times, most recently
from
377cde8
to
aa94e76
Compare
TheSpiritXIII
force-pushed
the
http-secret-interface
branch
3 times, most recently
from
3c3e1cc
to
4a41b93
Compare
TheSpiritXIII
force-pushed
the
http-secret-interface
branch
from
4a41b93
to
160c10d
Compare
Signed-off-by: Daniel Hrabovcak <thespiritxiii@gmail.com>
TheSpiritXIII
force-pushed
the
http-secret-interface
branch
from
160c10d
to
18ad275
Compare
bwplotka
approved these changes
May 9, 2024
There was a problem hiding this comment.
LGTM, thanks!
Exciting for prometheus/prometheus#13955 (comment) which this PR enables! ❤️
Disclaimer: @TheSpiritXIII is in my Google team. I tried to get more hands on this review for weeks, but no response. The secret provider feature was generally accepted 1, 2, so allowing myself to move forward after the careful review
| return "inline" | ||
| } | ||
|
|
||
| func (s *inlineSecret) immutable() bool { |
There was a problem hiding this comment.
nice, this will optimize things 👍🏽
MrAlias
pushed a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Jun 3, 2024
…5472) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://github.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://github.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#624 - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#623 - Add HTTP headers support to common HTTP client. by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#416 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#633 - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#632 - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#628 - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#630 - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#631 - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#629 - Use common interface to fetch secrets in HTTP client config by [@​TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#538 - Add support for secret refs via a secret manager by [@​TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#572 - oauth2RoundTripper: Avoid race condition and readability changes. by [@​bwplotka](https://github.com/bwplotka) in [prometheus/common#634 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#636 - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#638 - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#639 - feat: add time template helpers by [@​freak12techno](https://github.com/freak12techno) in [prometheus/common#627 #### New Contributors - [@​bwplotka](https://github.com/bwplotka) made their first contribution in [prometheus/common#634 - [@​freak12techno](https://github.com/freak12techno) made their first contribution in [prometheus/common#627 **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
MrAlias
pushed a commit
to open-telemetry/opentelemetry-go-contrib
that referenced
this pull request
Jun 3, 2024
…5709) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://github.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://github.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#624 - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#623 - Add HTTP headers support to common HTTP client. by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#416 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#633 - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#632 - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#628 - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#630 - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#631 - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#629 - Use common interface to fetch secrets in HTTP client config by [@​TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#538 - Add support for secret refs via a secret manager by [@​TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#572 - oauth2RoundTripper: Avoid race condition and readability changes. by [@​bwplotka](https://github.com/bwplotka) in [prometheus/common#634 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#636 - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#638 - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#639 - feat: add time template helpers by [@​freak12techno](https://github.com/freak12techno) in [prometheus/common#627 #### New Contributors - [@​bwplotka](https://github.com/bwplotka) made their first contribution in [prometheus/common#634 - [@​freak12techno](https://github.com/freak12techno) made their first contribution in [prometheus/common#627 **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Jun 4, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://github.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://github.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#624 - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#623 - Add HTTP headers support to common HTTP client. by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#416 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#633 - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#632 - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#628 - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#630 - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#631 - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#629 - Use common interface to fetch secrets in HTTP client config by [@​TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#538 - Add support for secret refs via a secret manager by [@​TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#572 - oauth2RoundTripper: Avoid race condition and readability changes. by [@​bwplotka](https://github.com/bwplotka) in [prometheus/common#634 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#636 - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#638 - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#639 - feat: add time template helpers by [@​freak12techno](https://github.com/freak12techno) in [prometheus/common#627 #### New Contributors - [@​bwplotka](https://github.com/bwplotka) made their first contribution in [prometheus/common#634 - [@​freak12techno](https://github.com/freak12techno) made their first contribution in [prometheus/common#627 **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jun 4, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://github.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://github.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#624 - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#623 - Add HTTP headers support to common HTTP client. by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#416 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#633 - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#632 - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#628 - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#630 - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#631 - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#629 - Use common interface to fetch secrets in HTTP client config by [@​TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#538 - Add support for secret refs via a secret manager by [@​TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#572 - oauth2RoundTripper: Avoid race condition and readability changes. by [@​bwplotka](https://github.com/bwplotka) in [prometheus/common#634 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#636 - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#638 - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#639 - feat: add time template helpers by [@​freak12techno](https://github.com/freak12techno) in [prometheus/common#627 #### New Contributors - [@​bwplotka](https://github.com/bwplotka) made their first contribution in [prometheus/common#634 - [@​freak12techno](https://github.com/freak12techno) made their first contribution in [prometheus/common#627 **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
|
Should we export the secret types implementations or the Downstream projects like thanos/cortex uses the methods that now receives the Ex: Ex of how we changed on this PR: |
This was referenced Jun 5, 2024
| // NewAuthorizationCredentialsRoundTripper adds the authorization credentials | ||
| // read from the provided secret to a request unless the authorization header | ||
| // has already been set. | ||
| func NewAuthorizationCredentialsRoundTripper(authType string, authCredentials secret, rt http.RoundTripper) http.RoundTripper { |
There was a problem hiding this comment.
Breaking change. Also secret is not exported.
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
](https://renovatebot.com){kind=link}
…n-telemetry#33363) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://github.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://github.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#624 - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#623 - Add HTTP headers support to common HTTP client. by [@&open-telemetry#8203;roidelapluie](https://github.com/roidelapluie) in [prometheus/common#416 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://github.com/prombot) in [prometheus/common#633 - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#632 - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#628 - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#630 - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#631 - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#629 - Use common interface to fetch secrets in HTTP client config by [@&open-telemetry#8203;TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#538 - Add support for secret refs via a secret manager by [@&open-telemetry#8203;TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#572 - oauth2RoundTripper: Avoid race condition and readability changes. by [@&open-telemetry#8203;bwplotka](https://github.com/bwplotka) in [prometheus/common#634 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://github.com/prombot) in [prometheus/common#636 - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#638 - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#639 - feat: add time template helpers by [@&open-telemetry#8203;freak12techno](https://github.com/freak12techno) in [prometheus/common#627 #### New Contributors - [@&open-telemetry#8203;bwplotka](https://github.com/bwplotka) made their first contribution in [prometheus/common#634 - [@&open-telemetry#8203;freak12techno](https://github.com/freak12techno) made their first contribution in [prometheus/common#627 **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 for secret provider support within
common. See: https://groups.google.com/g/prometheus-developers/c/WKOej_pnhXgThis change consolidates fetching secrets across all authorization types. Authorization types which previously had different structs per secret type now have a single type.
The unification helps with adding secret manager support which part 2 will include. There are two ways we could do this.