Add HTTP headers support to common HTTP client. #416

roidelapluie · 2022-11-28T10:20:09Z

This is named http_headers so it does not clash with blackbox exporter's headers and Prometheus remote client's headers, which are simple maps.

Signed-off-by: Julien Pivotto roidelapluie@o11y.eu

roidelapluie · 2022-11-28T10:32:22Z

Mailing list discussion: https://groups.google.com/g/prometheus-developers/c/p9HTlPzwUEo

jeromeinsf · 2022-12-07T00:50:18Z

Wondering if this will enable what was intended in #326

config/headers.go

LeviHarrison · 2022-12-21T12:55:50Z

config/headers.go

+	Headers       map[string][]string `yaml:"headers,omitempty" json:"headers,omitempty"`
+	SecretHeaders map[string][]Secret `yaml:"secret_headers,omitempty" json:"secret_headers,omitempty"`
+	Files         map[string][]string `yaml:"files,omitempty" json:"files,omitempty"`


I find this entire scheme a bit confusing, both in the non-uniformity of the names (we have normal headers, secret headers, and then just files, which I understand why can't be file headers but still), and also in the names themselves (secret headers could be interpreted as intended, a header with a secret value, or some sort of a "secret" header). Of course they'll be docs to clear this up but I still think it's less than ideal. Therefore, I propose we instead have an iterated:

type header struct { name/key string value string secret secret file string }

Which I think would be more clear and also allow for more complicated header appends. Generally a small difference though so feel free to ignore.

LeviHarrison · 2022-12-21T13:50:48Z

config/headers.go

+		if _, ok := reservedHeaders[http.CanonicalHeaderKey(k)]; ok {
+			return fmt.Errorf("setting header %q is not allowed", http.CanonicalHeaderKey(k))
+		}


It would make more sense for this check to come first

zetaab · 2023-12-30T12:48:08Z

@roidelapluie @LeviHarrison what is status in this PR? At least I am interested of this feature

Dronec · 2024-04-10T05:17:45Z

Me too! Adding headers to requests is a relatively trivial operation and multiple APIs support that

LeviHarrison · 2024-04-14T18:38:05Z

Just some small revisions

@roidelapluie friendly ping

This is named `http_headers` so it does not clash with blackbox exporter's headers and Prometheus remote client's headers, which are simple maps. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>

roidelapluie · 2024-04-16T12:52:10Z

@LeviHarrison here you go 🙂

LeviHarrison

LGTM, thanks

As usual we'll need to update Prom docs after this

…5472) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.53.0/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.53.0/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://github.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://github.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#624 - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#623 - Add HTTP headers support to common HTTP client. by [@roidelapluie](https://github.com/roidelapluie) in [prometheus/common#416 - Synchronize common files from prometheus/prometheus by [@prombot](https://github.com/prombot) in [prometheus/common#633 - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#632 - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#628 - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#630 - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@dependabot](https://github.com/dependabot) in [prometheus/common#631 - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#629 - Use common interface to fetch secrets in HTTP client config by [@TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#538 - Add support for secret refs via a secret manager by [@TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#572 - oauth2RoundTripper: Avoid race condition and readability changes. by [@bwplotka](https://github.com/bwplotka) in [prometheus/common#634 - Synchronize common files from prometheus/prometheus by [@prombot](https://github.com/prombot) in [prometheus/common#636 - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#638 - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#639 - feat: add time template helpers by [@freak12techno](https://github.com/freak12techno) in [prometheus/common#627 #### New Contributors - [@bwplotka](https://github.com/bwplotka) made their first contribution in [prometheus/common#634 - [@freak12techno](https://github.com/freak12techno) made their first contribution in [prometheus/common#627 **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…5709) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.53.0/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.53.0/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://github.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://github.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#624 - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#623 - Add HTTP headers support to common HTTP client. by [@roidelapluie](https://github.com/roidelapluie) in [prometheus/common#416 - Synchronize common files from prometheus/prometheus by [@prombot](https://github.com/prombot) in [prometheus/common#633 - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#632 - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#628 - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#630 - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@dependabot](https://github.com/dependabot) in [prometheus/common#631 - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#629 - Use common interface to fetch secrets in HTTP client config by [@TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#538 - Add support for secret refs via a secret manager by [@TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#572 - oauth2RoundTripper: Avoid race condition and readability changes. by [@bwplotka](https://github.com/bwplotka) in [prometheus/common#634 - Synchronize common files from prometheus/prometheus by [@prombot](https://github.com/prombot) in [prometheus/common#636 - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#638 - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#639 - feat: add time template helpers by [@freak12techno](https://github.com/freak12techno) in [prometheus/common#627 #### New Contributors - [@bwplotka](https://github.com/bwplotka) made their first contribution in [prometheus/common#634 - [@freak12techno](https://github.com/freak12techno) made their first contribution in [prometheus/common#627 **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.53.0/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.53.0/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://github.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://github.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#624 - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#623 - Add HTTP headers support to common HTTP client. by [@roidelapluie](https://github.com/roidelapluie) in [prometheus/common#416 - Synchronize common files from prometheus/prometheus by [@prombot](https://github.com/prombot) in [prometheus/common#633 - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#632 - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#628 - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#630 - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@dependabot](https://github.com/dependabot) in [prometheus/common#631 - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#629 - Use common interface to fetch secrets in HTTP client config by [@TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#538 - Add support for secret refs via a secret manager by [@TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#572 - oauth2RoundTripper: Avoid race condition and readability changes. by [@bwplotka](https://github.com/bwplotka) in [prometheus/common#634 - Synchronize common files from prometheus/prometheus by [@prombot](https://github.com/prombot) in [prometheus/common#636 - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#638 - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#639 - feat: add time template helpers by [@freak12techno](https://github.com/freak12techno) in [prometheus/common#627 #### New Contributors - [@bwplotka](https://github.com/bwplotka) made their first contribution in [prometheus/common#634 - [@freak12techno](https://github.com/freak12techno) made their first contribution in [prometheus/common#627 **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.53.0/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.53.0/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://github.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://github.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#624 - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#623 - Add HTTP headers support to common HTTP client. by [@roidelapluie](https://github.com/roidelapluie) in [prometheus/common#416 - Synchronize common files from prometheus/prometheus by [@prombot](https://github.com/prombot) in [prometheus/common#633 - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#632 - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#628 - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#630 - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@dependabot](https://github.com/dependabot) in [prometheus/common#631 - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@dependabot](https://github.com/dependabot) in [prometheus/common#629 - Use common interface to fetch secrets in HTTP client config by [@TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#538 - Add support for secret refs via a secret manager by [@TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#572 - oauth2RoundTripper: Avoid race condition and readability changes. by [@bwplotka](https://github.com/bwplotka) in [prometheus/common#634 - Synchronize common files from prometheus/prometheus by [@prombot](https://github.com/prombot) in [prometheus/common#636 - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#638 - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@dependabot](https://github.com/dependabot) in [prometheus/common#639 - feat: add time template helpers by [@freak12techno](https://github.com/freak12techno) in [prometheus/common#627 #### New Contributors - [@bwplotka](https://github.com/bwplotka) made their first contribution in [prometheus/common#634 - [@freak12techno](https://github.com/freak12techno) made their first contribution in [prometheus/common#627 **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

pracucci · 2024-06-07T14:25:40Z

@roidelapluie I think this PR introduced an issue in JSON marshalling. Could you take a look at #651 please?

yeya24 · 2024-06-12T22:06:56Z

config/http_config.go

@@ -311,6 +311,9 @@ type HTTPClientConfig struct {
 	EnableHTTP2 bool `yaml:"enable_http2" json:"enable_http2"`
 	// Proxy configuration.
 	ProxyConfig `yaml:",inline"`
+	// HTTPHeaders specify headers to inject in the requests. Those headers
+	// could be marshalled back to the users.
+	HTTPHeaders *Headers `yaml:"http_headers" json:"http_headers"`


Should we at least make it omit empty?

…n-telemetry#33363) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.53.0` -> `v0.54.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.53.0/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.53.0/v0.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.54.0`](https://github.com/prometheus/common/releases/tag/v0.54.0) [Compare Source](https://github.com/prometheus/common/compare/v0.53.0...v0.54.0) #### What's Changed - Bump golang.org/x/net from 0.22.0 to 0.23.0 in /sigv4 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#624 - Bump golang.org/x/net from 0.22.0 to 0.23.0 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#623 - Add HTTP headers support to common HTTP client. by [@&open-telemetry#8203;roidelapluie](https://github.com/roidelapluie) in [prometheus/common#416 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://github.com/prombot) in [prometheus/common#633 - Bump github.com/aws/aws-sdk-go from 1.51.11 to 1.51.32 in /sigv4 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#632 - Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#628 - Bump golang.org/x/net from 0.23.0 to 0.24.0 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#630 - Bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#631 - Bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#629 - Use common interface to fetch secrets in HTTP client config by [@&open-telemetry#8203;TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#538 - Add support for secret refs via a secret manager by [@&open-telemetry#8203;TheSpiritXIII](https://github.com/TheSpiritXIII) in [prometheus/common#572 - oauth2RoundTripper: Avoid race condition and readability changes. by [@&open-telemetry#8203;bwplotka](https://github.com/bwplotka) in [prometheus/common#634 - Synchronize common files from prometheus/prometheus by [@&open-telemetry#8203;prombot](https://github.com/prombot) in [prometheus/common#636 - Bump github.com/aws/aws-sdk-go from 1.51.32 to 1.53.14 in /sigv4 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#638 - Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /sigv4 by [@&open-telemetry#8203;dependabot](https://github.com/dependabot) in [prometheus/common#639 - feat: add time template helpers by [@&open-telemetry#8203;freak12techno](https://github.com/freak12techno) in [prometheus/common#627 #### New Contributors - [@&open-telemetry#8203;bwplotka](https://github.com/bwplotka) made their first contribution in [prometheus/common#634 - [@&open-telemetry#8203;freak12techno](https://github.com/freak12techno) made their first contribution in [prometheus/common#627 **Full Changelog**: prometheus/common@v0.53.0...v0.54.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

roidelapluie force-pushed the headers branch from 27796f3 to 49aba83 Compare November 28, 2022 10:29

roidelapluie requested a review from LeviHarrison December 8, 2022 12:08

roidelapluie force-pushed the headers branch 2 times, most recently from a7c7b9d to bb90569 Compare December 8, 2022 12:59

LeviHarrison reviewed Dec 21, 2022

View reviewed changes

pintohutch mentioned this pull request Jan 10, 2023

Support of sending custom header in Alertmanagers in operatorconfig GoogleCloudPlatform/prometheus-engine#307

Open

This was referenced Oct 30, 2023

Add support for Host header prometheus/prometheus#13009

Open

Support for specifying HTTP headers in scrape configs prometheus/prometheus#13098

Open

roidelapluie force-pushed the headers branch from bb90569 to 81f9859 Compare April 15, 2024 09:36

Add HTTP headers support to common HTTP client.

aeb616a

This is named `http_headers` so it does not clash with blackbox exporter's headers and Prometheus remote client's headers, which are simple maps. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>

roidelapluie force-pushed the headers branch from 81f9859 to aeb616a Compare April 15, 2024 09:45

SuperQ requested a review from LeviHarrison April 18, 2024 12:59

LeviHarrison approved these changes Apr 21, 2024

View reviewed changes

roidelapluie merged commit 36303a8 into prometheus:main Apr 29, 2024
7 checks passed

pracucci mentioned this pull request Jun 7, 2024

Fix HTTPClientConfig JSON marshalling #651

Merged

yeya24 reviewed Jun 12, 2024

View reviewed changes

yeya24 mentioned this pull request Jun 12, 2024

Set http_headers to be omit empty #655

Merged

roobre mentioned this pull request Jun 21, 2024

Build(deps): Bump the prometheus-go group across 1 directory with 2 updates grafana/synthetic-monitoring-agent#736

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add HTTP headers support to common HTTP client. #416

Add HTTP headers support to common HTTP client. #416

roidelapluie commented Nov 28, 2022

roidelapluie commented Nov 28, 2022

jeromeinsf commented Dec 7, 2022 •

edited

Loading

LeviHarrison Dec 21, 2022

LeviHarrison Dec 21, 2022

zetaab commented Dec 30, 2023

Dronec commented Apr 10, 2024

LeviHarrison commented Apr 14, 2024

roidelapluie commented Apr 16, 2024

LeviHarrison left a comment

pracucci commented Jun 7, 2024

yeya24 Jun 12, 2024

Add HTTP headers support to common HTTP client. #416

Add HTTP headers support to common HTTP client. #416

Conversation

roidelapluie commented Nov 28, 2022

roidelapluie commented Nov 28, 2022

jeromeinsf commented Dec 7, 2022 • edited Loading

LeviHarrison Dec 21, 2022

Choose a reason for hiding this comment

LeviHarrison Dec 21, 2022

Choose a reason for hiding this comment

zetaab commented Dec 30, 2023

Dronec commented Apr 10, 2024

LeviHarrison commented Apr 14, 2024

roidelapluie commented Apr 16, 2024

LeviHarrison left a comment

Choose a reason for hiding this comment

pracucci commented Jun 7, 2024

yeya24 Jun 12, 2024

Choose a reason for hiding this comment

jeromeinsf commented Dec 7, 2022 •

edited

Loading