Autoupdater breaks install #358

derStephan · 2022-04-30T10:33:34Z

Describe the bug
In snappy v2.15.0, I tried to use the new shiny auto-updater. It told me that there is a new version. When I clicked "update", the page reloaded after about a second and showed me that there was still an update to v2.15.1. I waited a minute and tried to reload the page where I ended up stuck with this message:

An error occurred.
Please refresh the page and try again. Failed loading /snappy/snappymail/v/2.15.1/static/js/min/libs.min.js

After that, I deleted v2.15.1 folder and changed the version in index.php to

define('APP_VERSION', '2.15.0');

That made the software work againand I could reproduce the behaviour again.

To Reproduce
Steps to reproduce the behavior:

Go to admin interface - about
Click on update
See error Failed loading /snappy/snappymail/v/2.15.1/static/js/min/libs.min.js

Expected behavior
Updated to v2.15.1

log
log-2022-04-30.txt

Desktop (please complete the following information):

Firefox 99.0.1, Windows 10 x64
SnappyMail Version 2.15.0

the-djmaze · 2022-04-30T14:30:26Z

Thanks for the log, but we need different logs.

the Apache/Nginx error log
PHP error log

This is because we want to know WHY libs.min.js does not exist.
Why is not extracted from the latest.tar.gz?
Or is there a different error?

derStephan · 2022-05-01T18:43:08Z

Thanks for the log, but we need different logs.

😂 Could have thought about it.

I attached the apache error_log.txt. Unfortunately, there is no PHP error log.

Looks like a permission problem?

the-djmaze · 2022-05-02T18:18:53Z

I see:

[fcgid:warn] [pid 27006] [client 92.117.61.39:30252] mod_fcgid: stderr: Extract to /…/httpdocs/mail/snappy
[fcgid:warn] [pid 27006] [client 92.117.61.39:30252] mod_fcgid: stderr: Update success

So that means the extraction worked.

But then:

AH00529: /…/httpdocs/mail/snappy/snappymail/v/2.15.1/.htaccess pcfg_openfile: unable to check htaccess file, ensure it is readable and that '/…/httpdocs/mail/snappy/snappymail/v/2.15.1/' is executable

Are you using SELinux? If so, you should check the configuration.

derStephan · 2022-05-03T04:49:55Z

Are you using SELinux? If so, you should check the configuration.

This is a shared hoster using Plesk. I really don't know what is running in the background there. I can redo the test and check permissions on files and folders if this helps.

Bagu · 2022-05-04T08:40:42Z

Hello,

Same problem with different configuration.
Server : Windows x64
Apache : 2.4.53
Php : 7.4.29
FCGID : 2.3.10

No error in php and apache log.
Access rights are double checked and ok

derStephan · 2022-05-05T11:13:18Z

If @Bagu has this problem on windows then it is probably not related to SELinux.

Is there anything we can do for you here? Do you want to have a look at my shared hoster to see what's going on?

Bagu · 2022-05-06T17:36:58Z

Hello,

I have a lead. Looking closer, I have this message that appears in the console of firefox:
The resource at "https://mydomain.com/snappymail/v/2.15.1/static/js/min/libs.min.js" has been blocked due to an incorrect MIME type ("text/html") (X-Content-Type-Options: nosniff)

And when i try a direct access :
Your browser sent a request that this server could not understand.

derStephan · 2022-05-30T13:21:05Z

Did you disable auto updater feature? I wanted to give the updater another try.

I am currently on 2.16.1. The about page tells me that there is a 2.16.2 with a link to releases. But there is no button for auto update anymore.

Is there anything, we can help you with?

Bagu · 2022-05-30T15:16:14Z

Nothing new with this version.
To make it work, i have to replace every min version by the standard version.
Eg : i replace admin.min.js by a renamed version of admin.js

It seem that there is a mime type problem ?

derStephan · 2022-09-28T05:39:16Z

Any news on the auto-updater?

the-djmaze · 2022-11-17T21:01:54Z

Somehow i can't reproduce this issue.
All my systems are PHP-FPM.
SELinux is in permissive mode and the log shows no issues for it.

Did you find out?

Bagu · 2022-11-17T21:11:35Z

Nop. I'm under php 8.1.12 + fcgid + apache 2.4.54.
Nothing in php logs
Nothing in apache logs
Message "An error occurred. Please refresh the page and try again. Failed loading /snappymail\v\2.21.3\static/js/min/libs.min.js" shown in web page

Mozilla console show that app.min.css and libs.min.js can load and type is shown as html instead of css and js type.

the-djmaze · 2022-11-17T21:27:58Z

Open the Firefox developer tools.
Open the network tab.
Find the libs.min.js request and click on it.
On the right click on the response tab and see the content.
It should show the HTML and error/message why it failed.

Bagu · 2022-11-19T22:26:08Z

It show an error 400.

État 400 Bad Request
Version HTTP/3
Transfert 748 o (taille 0 o)
Politique de référent same-origin

La ressource à l’adresse « https://my-webmail-address/snappymail/v/2.21.3/static/css/app.min.css » a été bloquée en raison d’un type MIME (« text/html ») incorrect (X-Content-Type-Options: nosniff).
La ressource à l’adresse « https://my-webmail-address/snappymail/v/2.21.3/static/js/min/libs.min.js » a été bloquée en raison d’un type MIME (« text/html ») incorrect (X-Content-Type-Options: nosniff).

the-djmaze · 2023-02-06T19:08:17Z

I think i found the problem.
On extraction the directories are 0700 and your Apache runs as a different user then PHP.
I've made a modification to the upgrade script to set them to 0755.

But i also need to check the umask() and after that it might work.

Bagu · 2023-02-06T19:36:48Z

Good evening,
I have just tested the version available on github. There is no more the error concerning
https://my-webmail-address/snappymail/v/0.0.0/static/js/min/libs.min.js

but the one concerning
https://my-webmail-address/snappymail/v/0.0.0/static/css/app.min.css

is still there.
Is there a similar correction missing?
Thanks

the-djmaze · 2023-02-06T22:17:23Z

Could be, i'm still investigating

Bagu · 2023-05-15T18:41:53Z

I try v2.27.3 and still having the problem. I try remove every .htaccess modification of my vhost, but i don"t have any success.

derStephan · 2023-06-06T05:55:42Z

Hi. Any news on this one? Is there anything we can help with? I could do some testing, if you needed that.

Bagu · 2023-06-27T10:22:11Z

I've done a test : if i don't use HTTPS, it work.
An idea ?

the-djmaze · 2023-07-03T09:51:38Z

I've done a test : if i don't use HTTPS, it work.

Hmmm, i'm shooting in the dark. But maybe an issue in the HTTP/2 protocol handling?
I will think about it and see if something can be done.

Bagu · 2023-07-03T11:14:18Z

I've done a test : if i don't use HTTPS, it work.

Hmmm, i'm shooting in the dark. But maybe an issue in the HTTP/2 protocol handling? I will think about it and see if something can be done.

I did some tests by disabling mod_httpd2. Unfortunately, the result is the same. Several files are not sent by Apache when using https.

Bagu · 2023-08-03T09:32:03Z

I find the problem in my configuration :

	<IfModule mod_headers.c>
		# Sert des fichiers CSS compressés par brotli, s'ils existent
		# et si le client supporte brotli.
		RewriteCond "%{HTTP:Accept-encoding}" "br"
		RewriteCond "%{REQUEST_FILENAME}\.br" "-s"
		RewriteRule "^(.*)\.css"              "$1\.css\.br" [QSA]

		# Sert des fichiers JS compressés par brotli, s'ils existent
		# et si le client supporte brotli.
		RewriteCond "%{HTTP:Accept-encoding}" "br"
		RewriteCond "%{REQUEST_FILENAME}\.br" "-s"
		RewriteRule "^(.*)\.js"               "$1\.js\.br" [QSA]

		# Serve correct content types, and prevent double compression.
		RewriteRule "\.css\.br$" "-" [T=text/css,E=no-gzip:1]
		RewriteRule "\.js\.br$"  "-" [T=text/javascript,E=no-gzip:1]
		
		# Sert des types de contenu corrects, et évite la double compression.
		RewriteRule "\.css\.gz$" "-" [T=text/css,E=no-brotli:1]
		RewriteRule "\.js\.gz$"  "-" [T=text/javascript,E=no-brotli:1]

		<FilesMatch "(\.js\.br|\.css\.br)$">
			# Sert un type d'encodage correct.
			Header append Content-Encoding br

			# Force les mandataires à mettre en cache séparément les fichiers css/js
			# compressés ou non par brotli.
			Header append Vary Accept-Encoding
		</FilesMatch>
	</IfModule>

If i remove these lines, snappy work in http and https.

…, #1238, #1320

derStephan · 2023-12-12T08:32:51Z

I tried auto updater again and unfortunately, it still does not work. There are a number of 403 errors with the message You don't have permission to access this resource.Server unable to read htaccess file, denying access to be safe

the-djmaze · 2023-12-12T12:14:28Z

Correct! The folders static and themes are 0700 and not 0755.
After next release the upgrades should work and the right chmod is applied.

If not there is probably a (selinux?) permissions conflict.

derStephan · 2023-12-13T05:32:10Z

So fixing rights to these folders will help for now?

the-djmaze · 2023-12-13T07:19:10Z

Yes it should

derStephan · 2023-12-15T05:08:38Z

yes, that fixed it. Thank you.

derStephan · 2023-12-30T10:44:07Z

I tried to auto update to current version 2.32.0 and it is the same problem again. Folder permissions were 0700 again. After setting them to 0755 manually, it worked again.

the-djmaze · 2023-12-31T11:34:10Z

Correct!
With the next update it should work fine

derStephan · 2024-01-23T07:54:06Z

I can confirm that it worked this time. Thanks!!!

the-djmaze · 2024-01-23T09:22:09Z

your welcome

jeroenim0 mentioned this issue Jan 17, 2023

Snappymail error after upgrade to 2.24.5 #862

Closed

the-djmaze pushed a commit that referenced this issue Feb 7, 2023

On upgrade set umask and chmod files for #358

276cbc2

the-djmaze mentioned this issue Jun 6, 2023

Incorrect setting of folder rights when updating the application via the admin panel. #1155

Closed

the-djmaze pushed a commit that referenced this issue Jul 3, 2023

Change for #358

825ba99

the-djmaze pushed a commit that referenced this issue Nov 22, 2023

Added a test due to Failed loading libs.min.js #358, #862, #890, #895…

3bff355

…, #1238, #1320

the-djmaze closed this as completed Dec 3, 2023

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autoupdater breaks install #358

Autoupdater breaks install #358

derStephan commented Apr 30, 2022

the-djmaze commented Apr 30, 2022

derStephan commented May 1, 2022 •

edited

Loading

the-djmaze commented May 2, 2022

derStephan commented May 3, 2022

Bagu commented May 4, 2022

derStephan commented May 5, 2022

Bagu commented May 6, 2022 •

edited

Loading

derStephan commented May 30, 2022

Bagu commented May 30, 2022

derStephan commented Sep 28, 2022

the-djmaze commented Nov 17, 2022

Bagu commented Nov 17, 2022 •

edited

Loading

the-djmaze commented Nov 17, 2022

Bagu commented Nov 19, 2022 •

edited

Loading

the-djmaze commented Feb 6, 2023

Bagu commented Feb 6, 2023

the-djmaze commented Feb 6, 2023

Bagu commented May 15, 2023

derStephan commented Jun 6, 2023

Bagu commented Jun 27, 2023

the-djmaze commented Jul 3, 2023

Bagu commented Jul 3, 2023

Bagu commented Aug 3, 2023

derStephan commented Dec 12, 2023 •

edited

Loading

the-djmaze commented Dec 12, 2023

derStephan commented Dec 13, 2023

the-djmaze commented Dec 13, 2023

derStephan commented Dec 15, 2023

derStephan commented Dec 30, 2023

the-djmaze commented Dec 31, 2023

derStephan commented Jan 23, 2024

the-djmaze commented Jan 23, 2024

Autoupdater breaks install #358

Autoupdater breaks install #358

Comments

derStephan commented Apr 30, 2022

the-djmaze commented Apr 30, 2022

derStephan commented May 1, 2022 • edited Loading

the-djmaze commented May 2, 2022

derStephan commented May 3, 2022

Bagu commented May 4, 2022

derStephan commented May 5, 2022

Bagu commented May 6, 2022 • edited Loading

derStephan commented May 30, 2022

Bagu commented May 30, 2022

derStephan commented Sep 28, 2022

the-djmaze commented Nov 17, 2022

Bagu commented Nov 17, 2022 • edited Loading

the-djmaze commented Nov 17, 2022

Bagu commented Nov 19, 2022 • edited Loading

the-djmaze commented Feb 6, 2023

Bagu commented Feb 6, 2023

the-djmaze commented Feb 6, 2023

Bagu commented May 15, 2023

derStephan commented Jun 6, 2023

Bagu commented Jun 27, 2023

the-djmaze commented Jul 3, 2023

Bagu commented Jul 3, 2023

Bagu commented Aug 3, 2023

derStephan commented Dec 12, 2023 • edited Loading

the-djmaze commented Dec 12, 2023

derStephan commented Dec 13, 2023

the-djmaze commented Dec 13, 2023

derStephan commented Dec 15, 2023

derStephan commented Dec 30, 2023

the-djmaze commented Dec 31, 2023

derStephan commented Jan 23, 2024

the-djmaze commented Jan 23, 2024

derStephan commented May 1, 2022 •

edited

Loading

Bagu commented May 6, 2022 •

edited

Loading

Bagu commented Nov 17, 2022 •

edited

Loading

Bagu commented Nov 19, 2022 •

edited

Loading

derStephan commented Dec 12, 2023 •

edited

Loading