SLR Support #2081
SLR Support #2081
Conversation
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "tribe-common", | |||
| "version": "5.2.7", | |||
| "version": "5.4.0-dev", | |||
| @@ -559,14 +564,14 @@ function tribe_format_currency( $cost, $post_id = null, $currency_symbol = null, | |||
| * | |||
| * @category Events | |||
| * @param string $optionName Name of the option to retrieve. | |||
| * @param string $default Value to return if no such option is found. | |||
| * @param string $default Value to return if no such option is found. | |||
There was a problem hiding this comment.
Can you fix the rest of the docblock spacing, since you started?
stratease
added
the
needs release
src/Tribe/Assets.php
Outdated
| if ( ! empty( $asset->origin_url ) ) { | ||
| $asset->origin_url = trailingslashit( $asset->origin_url ); | ||
| } | ||
| $extension = substr( $file, strrpos( $file, '.' ) + 1 ); |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space
src/Tribe/Assets.php
Outdated
| $asset->origin_url = trailingslashit( $asset->origin_url ); | ||
| } | ||
| $extension = substr( $file, strrpos( $file, '.' ) + 1 ); | ||
| $plugin_path = ! empty( $origin->plugin_path ) ? $origin->plugin_path : $origin->pluginPath; |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase
Object property "$pluginPath" is not in valid snake_case format, try "$plugin_path"
src/Tribe/Assets.php
Outdated
| $plugin_path = ! empty( $origin->plugin_path ) ? $origin->plugin_path : $origin->pluginPath; | ||
|
|
||
| // Infer the type from the file extension, if not passed. | ||
| $type = empty( $arguments['type'] ) ? $extension : $arguments['type']; |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.Formatting.MultipleStatementAlignment.IncorrectWarning
Equals sign not aligned correctly; expected 1 space but found 3 spaces
lucatume
force-pushed
the
feat/slr-support
branch
from
252a5d7
to
575123f
Compare
src/Tribe/Assets.php
Outdated
| // Try to enqueue the minified version of the file if not debugging scripts or the file is not available. | ||
| if ( ! str_contains( $file, '.min.' ) ) { | ||
| // From `something.js` to `something.min.js`. | ||
| $minified_file = substr( $file, 0, - ( strlen( $extension ) + 1 ) ) . '.min.' . $extension; |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 4 spaces but found 3 spaces
src/Tribe/Assets.php
Outdated
| $asset->type = 'js'; | ||
| } elseif ( substr( $asset->file, -4, 4 ) === '.css' ) { | ||
| $asset->type = 'css'; | ||
| $extension = substr( $file, strrpos( $file, '.' ) + 1 ); |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.Formatting.MultipleStatementAlignment.IncorrectWarning
Equals sign not aligned correctly; expected 1 space but found 3 spaces
lucatume
force-pushed
the
feat/slr-support
branch
from
3d31bfe
to
cbe471b
Compare
…-licensing-fix-uopz Uplink - Fix incorrect `uopz_redefine` arguments used within `set_const_value`
…-licensing [SL-157] Support Uplink Licensing
…version Updating uplink to version 2
…foreinvalid-license Check Uplink before invalid license
SL-142 support work
No description provided.