fix(example app): use boolean values for FacebookAutoLogAppEventsEnabled and FacebookAdvertiserIDCollectionEnabled

[yaroslavnikiforov]

Fixes #564

[mikehardy]

This is a bit obscure, but this is the wrong place to change this 😆

react-native-fbsdk-next/refresh-example.sh

Lines 114 to 117 in 0621760

	sed -i -e 's/^<\/dict>/ <key>FacebookAutoLogAppEventsEnabled<\/key>\n <string>FALSE<\/string>\n<\/dict>/' ios/RNFBSDKExample/Info.plist
	rm -f ios/RNFBSDKExample/Info.plist??
	sed -i -e 's/^<\/dict>/ <key>FacebookAdvertiserIDCollectionEnabled<\/key>\n <string>FALSE<\/string>\n<\/dict>/' ios/RNFBSDKExample/Info.plist
	rm -f ios/RNFBSDKExample/Info.plist??

Is where to change it, then you re-run refresh-example.sh

What!? Why? Keeping the example up to date is actually one of the most irritating burdens of being a react-native module maintainer, so I automate it as much as possible - and this is how, in this repo

I think it looks pretty easy to edit there though - that is the required changes are reasonably obvious I think? Can you make them in the script instead? Many thanks

[yaroslavnikiforov]

I updated my commit. But refresh-example.sh upgrades the react-native version and creates a bigger diff, should those changes be part of this PR?

[mikehardy]

I think it's fine to leave the concrete example update to another commit - I usually do two commits, one to update refresh-example.sh and one that then has the result of re-running it

But I believe I ran this pretty recently so it should be fine, and if I did not run it + commit the result recently then there was a reason and it means I have something else to fix - which would be out of scope for this PR

TL;DR: this is great, your intended + desired change is now in the example and in the refresh script so it's permanent and that's really the point

Thanks again!

[github-actions]

🎉 This PR is included in version 13.1.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀