Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example app): use boolean values for FacebookAutoLogAppEventsEnabled and FacebookAdvertiserIDCollectionEnabled #565

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions RNFBSDKExample/ios/RNFBSDKExample/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@
<string>fbshareextension</string>
</array>
<key>FacebookAutoLogAppEventsEnabled</key>
<string>FALSE</string>
<false/>
<key>FacebookAdvertiserIDCollectionEnabled</key>
<string>FALSE</string>
<false/>
<key>CFBundleURLTypes</key>
<array>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions refresh-example.sh
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,9 @@ sed -i -e 's/<\/application>/ <meta-data android:name="com.facebook.sdk.AutoLog
rm -f android/app/src/main/AndroidManifest.xml??
sed -i -e 's/<\/application>/ <meta-data android:name="com.facebook.sdk.AdvertiserIDCollectionEnabled" android:value="false"\/>\n <\/application>/' android/app/src/main/AndroidManifest.xml
rm -f android/app/src/main/AndroidManifest.xml??
sed -i -e 's/^<\/dict>/ <key>FacebookAutoLogAppEventsEnabled<\/key>\n <string>FALSE<\/string>\n<\/dict>/' ios/RNFBSDKExample/Info.plist
sed -i -e 's/^<\/dict>/ <key>FacebookAutoLogAppEventsEnabled<\/key>\n <false\/>\n<\/dict>/' ios/RNFBSDKExample/Info.plist
rm -f ios/RNFBSDKExample/Info.plist??
sed -i -e 's/^<\/dict>/ <key>FacebookAdvertiserIDCollectionEnabled<\/key>\n <string>FALSE<\/string>\n<\/dict>/' ios/RNFBSDKExample/Info.plist
sed -i -e 's/^<\/dict>/ <key>FacebookAdvertiserIDCollectionEnabled<\/key>\n <false\/>\n<\/dict>/' ios/RNFBSDKExample/Info.plist
rm -f ios/RNFBSDKExample/Info.plist??

# On iOS and Android you have to add entries for various query schemes (Android S+) and allowed URLs etc
Expand Down
Loading