Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style cleanup with black, flake8 and isort #77

Merged
merged 19 commits into from
Dec 2, 2022
Merged

Code style cleanup with black, flake8 and isort #77

merged 19 commits into from
Dec 2, 2022

Conversation

koenvervloesem
Copy link
Member

Description:

Cleans up code style with black, flake8 and isort. This also adds a pre-commit hook for these tools and runs them as part of a GitHub Actions workflow, so code style will stay consistent. Thanks to this cleanup, the code can be more easily refactored and extended later.

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@koenvervloesem
Test for membership should be 'not in' (Flake8 rule E713)
f3809aa
@koenvervloesem
Whitespace fixes (various Flake8 rules)
652c83a
@koenvervloesem
Don't import unused functions getProperties and getAttribute (Flake8 …
c41e3b1 
…rule F401)
@koenvervloesem
Don't use f-string when there's no placeholder (Flake8 rule F541)
b7da125
@koenvervloesem
Do not use bare 'except' (Flake8 rule E722)
874f8bd
@koenvervloesem
Run black and add it to pre-commit
121b01a
@koenvervloesem
Use lazy % formatting in logging functions
14341b2
@koenvervloesem
Add flake8 to pre-commit
cce28c2
@koenvervloesem
Add use of pre-commit to development docs
0d3d1a0
@koenvervloesem
Run pre-commit in GitHub Actions workflow
f7cea96
@koenvervloesem
Run isort
6dfe744
@koenvervloesem
Specify encoding when opening file (Pylint rule W1514)
1acf865
@koenvervloesem
Remove useless super() delegation (Pylint rule W0246)
20422fb
@koenvervloesem
Remove useless super() delegation (Pylint rule W0246)
25e93fd
@koenvervloesem
Add docstrings to classes and methods
2aa7d70
@koenvervloesem
Use PascalCase naming style for classes
0c7aea3
@koenvervloesem
Use snake_case for variable and argument names
1fc6186
@koenvervloesem
Explicitly re-raise new exception from other one for better traceback…
b375ff0 
…s (Pylint rule W0707)
@koenvervloesem
Remove unneeded run invocation from ble_gateway.py
b28d4a2
@koenvervloesem koenvervloesem mentioned this pull request Nov 17, 2022
Closed
3 tasks
@1technophile
Copy link
Member

LGTM

@1technophile 1technophile merged commit 22d5eb1 into development Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1technophile 1technophile Awaiting requested review from 1technophile

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koenvervloesem @1technophile