Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style cleanup with black, flake8 and isort #77

Merged
merged 19 commits into from
Dec 2, 2022
Merged

Code style cleanup with black, flake8 and isort #77

merged 19 commits into from
Dec 2, 2022

Commits on Nov 12, 2022

  1. Test for membership should be 'not in' (Flake8 rule E713)

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    f3809aa View commit details
    Browse the repository at this point in the history

  2. Whitespace fixes (various Flake8 rules)

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    652c83a View commit details
    Browse the repository at this point in the history

  3. Don't import unused functions getProperties and getAttribute (Flake8 … 

    …rule F401)
    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    c41e3b1 View commit details
    Browse the repository at this point in the history

  4. Don't use f-string when there's no placeholder (Flake8 rule F541)

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    b7da125 View commit details
    Browse the repository at this point in the history

  5. Do not use bare 'except' (Flake8 rule E722)

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    874f8bd View commit details
    Browse the repository at this point in the history

  6. Run black and add it to pre-commit

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    121b01a View commit details
    Browse the repository at this point in the history

  7. Use lazy % formatting in logging functions

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    14341b2 View commit details
    Browse the repository at this point in the history

  8. Add flake8 to pre-commit

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    cce28c2 View commit details
    Browse the repository at this point in the history

  9. Add use of pre-commit to development docs

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    0d3d1a0 View commit details
    Browse the repository at this point in the history

  10. Run pre-commit in GitHub Actions workflow

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    f7cea96 View commit details
    Browse the repository at this point in the history

  11. Run isort

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    6dfe744 View commit details
    Browse the repository at this point in the history

  12. Specify encoding when opening file (Pylint rule W1514)

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    1acf865 View commit details
    Browse the repository at this point in the history

  13. Remove useless super() delegation (Pylint rule W0246)

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    20422fb View commit details
    Browse the repository at this point in the history

  14. Remove useless super() delegation (Pylint rule W0246)

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    25e93fd View commit details
    Browse the repository at this point in the history

  15. Add docstrings to classes and methods

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    2aa7d70 View commit details
    Browse the repository at this point in the history

  16. Use PascalCase naming style for classes

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    0c7aea3 View commit details
    Browse the repository at this point in the history

  17. Use snake_case for variable and argument names

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    1fc6186 View commit details
    Browse the repository at this point in the history

  18. Explicitly re-raise new exception from other one for better traceback… 

    …s (Pylint rule W0707)
    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    b375ff0 View commit details
    Browse the repository at this point in the history

  19. Remove unneeded run invocation from ble_gateway.py

    @koenvervloesem
    koenvervloesem committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    b28d4a2 View commit details
    Browse the repository at this point in the history