update webpack to v3.0 #1693

ohadlevy · 2017-06-22T09:51:30Z

No description provided.

dLobatog · 2017-06-23T12:55:54Z

http://koji.katello.org/kojifiles/work/tasks/8155/8155/build.log fails because there's no npm:

+ npm cache add --cache ./npm_cache /builddir/build/SOURCES/webpack-3.0.0.tgz
/var/tmp/rpm-tmp.ywlyav: line 32: npm: command not found

ohadlevy · 2017-06-24T18:56:52Z

@dLobatog any idea why there is no npm?

ohadlevy · 2017-06-24T18:56:57Z

[test]

ohadlevy · 2017-06-26T05:46:48Z

@ehelms the tests fails because of it cant find packages introduced in this ps, is there a way to test all changes in one pr? or must i break it down to a PR per package? thanks.

ehelms · 2017-06-26T16:31:55Z

@ohadlevy Traditionally these kinds of changes have been done in a PR like this one. But it puts a burden on the reviewer to check it out locally, run mockchain builds to ensure everything passes. So while I prefer smaller individual PRs to address, this is fine but will take me a (or another maintainer) a bit longer to get to.

ehelms · 2017-07-04T19:17:15Z

@ohadlevy How many packages are updated in this PR? It's really hard to tell with the number of files changed what all has been changed and waht is going to need updating and what are new packages. If you could either list that out or split this up it would help a ton.

ehelms · 2017-07-05T22:26:42Z

@ohadlevy there appear to be some actual build errors when looking at (http://ci.theforeman.org/job/packaging_test_pull_request/2329/) that aren't in root log (typically the case for when dependent packages are missing. For example, I see (http://koji.katello.org/koji/taskinfo?taskID=8560) failing in the build.log with what appears to be a legitimate error. Can you check these and confirm?

mmoll · 2017-07-10T13:20:39Z

@ohadlevy what's the status here?

ohadlevy · 2017-07-10T19:15:50Z

@ehelms I'm not seeing the actual error - does koji no longer keeps it?

ehelms · 2017-07-10T21:01:24Z

@ohadlevy it will keep scratch builds for a short time, we can re-run it

ehelms · 2017-07-10T21:01:28Z

[test]

ehelms · 2017-07-11T00:53:59Z

I had to make the following changes to get the builds passing:

diff --git a/nodejs-extract-text-webpack-plugin/nodejs-bundle-extract-text-webpack-plugin.spec b/nodejs-extract-text-webpack-plugin/nodejs-extract-text-webpack-plugin.spec
similarity index 92%
rename from nodejs-extract-text-webpack-plugin/nodejs-bundle-extract-text-webpack-plugin.spec
rename to nodejs-extract-text-webpack-plugin/nodejs-extract-text-webpack-plugin.spec
index 5ebdea2..a553bc3 100644
--- a/nodejs-extract-text-webpack-plugin/nodejs-bundle-extract-text-webpack-plugin.spec
+++ b/nodejs-extract-text-webpack-plugin/nodejs-extract-text-webpack-plugin.spec
@@ -51,8 +51,8 @@ Provides: bundled-npm(fast-deep-equal) = 0.1.0
 Provides: bundled-npm(json-stable-stringify) = 1.0.1
 Provides: bundled-npm(co) = 4.6.0
 Provides: bundled-npm(jsonify) = 0.0.0
-AutoReq: no 
-AutoProv: no 
+AutoReq: no
+AutoProv: no
 
 
 %description
@@ -72,13 +72,10 @@ npm install --cache-min Infinity --cache . --no-optional --global-style true %{n
 %install
 mkdir -p %{buildroot}%{nodejs_sitelib}/%{npm_name}
 cd node_modules/extract-text-webpack-plugin
-cp -pfr CHANGELOG.md ExtractedModule.js LICENSE OrderUndefinedError.js README.md index.js loader.js package.json schema node_modules %{buildroot}%{nodejs_sitelib}/%{npm_name}
+cp -pfr CHANGELOG.md ExtractedModule.js OrderUndefinedError.js README.md index.js loader.js package.json schema node_modules %{buildroot}%{nodejs_sitelib}/%{npm_name}
 cp -pf CHANGELOG.md README.md ../../
 # If any binaries are included, symlink them to bindir here
 
-
-%nodejs_symlink_deps
-
 %if 0%{?enable_tests}
 %check
 %{nodejs_symlink_deps} --check
@@ -88,7 +85,6 @@ cp -pf CHANGELOG.md README.md ../../
 %files
 %{nodejs_sitelib}/%{npm_name}
 
-%doc LICENSE
 %doc CHANGELOG.md
 %doc README.md
 
diff --git a/nodejs-fbjs/nodejs-bundle-fbjs.spec b/nodejs-fbjs/nodejs-fbjs.spec
similarity index 90%
rename from nodejs-fbjs/nodejs-bundle-fbjs.spec
rename to nodejs-fbjs/nodejs-fbjs.spec
index 9c5ed42..453f187 100644
--- a/nodejs-fbjs/nodejs-bundle-fbjs.spec
+++ b/nodejs-fbjs/nodejs-fbjs.spec
@@ -1,6 +1,3 @@
-# FIXME
-# Remove nodejs_symlink_deps if installing bundled module with NPM
-
 %global npm_name fbjs
 %global enable_tests 0
 
@@ -47,8 +44,8 @@ Provides: bundled-npm(node-fetch) = 1.7.1
 Provides: bundled-npm(is-stream) = 1.1.0
 Provides: bundled-npm(encoding) = 0.1.12
 Provides: bundled-npm(iconv-lite) = 0.4.18
-AutoReq: no 
-AutoProv: no 
+AutoReq: no
+AutoProv: no
 
 
 %description
@@ -68,13 +65,10 @@ npm install --cache-min Infinity --cache . --no-optional --global-style true %{n
 %install
 mkdir -p %{buildroot}%{nodejs_sitelib}/%{npm_name}
 cd node_modules/fbjs
-cp -pfr CHANGELOG.md LICENSE PATENTS README.md flow index.js lib module-map.json package.json node_modules %{buildroot}%{nodejs_sitelib}/%{npm_name}
+cp -pfr CHANGELOG.md PATENTS README.md flow index.js lib module-map.json package.json node_modules %{buildroot}%{nodejs_sitelib}/%{npm_name}
 cp -pf CHANGELOG.md README.md ../../
 # If any binaries are included, symlink them to bindir here
 
-
-%nodejs_symlink_deps
-
 %if 0%{?enable_tests}
 %check
 %{nodejs_symlink_deps} --check
@@ -84,7 +78,6 @@ cp -pf CHANGELOG.md README.md ../../
 %files
 %{nodejs_sitelib}/%{npm_name}
 
-%doc LICENSE
 %doc CHANGELOG.md
 %doc README.md
 
diff --git a/nodejs-stats-webpack-plugin/nodejs-bundle-stats-webpack-plugin.spec b/nodejs-stats-webpack-plugin/nodejs-stats-webpack-plugin.spec
similarity index 84%
rename from nodejs-stats-webpack-plugin/nodejs-bundle-stats-webpack-plugin.spec
rename to nodejs-stats-webpack-plugin/nodejs-stats-webpack-plugin.spec
index 6d23add..aae37a6 100644
--- a/nodejs-stats-webpack-plugin/nodejs-bundle-stats-webpack-plugin.spec
+++ b/nodejs-stats-webpack-plugin/nodejs-stats-webpack-plugin.spec
@@ -1,6 +1,3 @@
-# FIXME
-# Remove nodejs_symlink_deps if installing bundled module with NPM
-
 %global npm_name stats-webpack-plugin
 %global enable_tests 0
 
@@ -21,8 +18,8 @@ ExclusiveArch: %{nodejs_arches} noarch
 
 Provides: bundled-npm(stats-webpack-plugin) = 0.6.1
 Provides: bundled-npm(lodash) = 4.17.4
-AutoReq: no 
-AutoProv: no 
+AutoReq: no
+AutoProv: no
 
 
 %description
@@ -42,13 +39,10 @@ npm install --cache-min Infinity --cache . --no-optional --global-style true %{n
 %install
 mkdir -p %{buildroot}%{nodejs_sitelib}/%{npm_name}
 cd node_modules/stats-webpack-plugin
-cp -pfr LICENSE README.md index.js package.json node_modules %{buildroot}%{nodejs_sitelib}/%{npm_name}
+cp -pfr README.md index.js package.json node_modules %{buildroot}%{nodejs_sitelib}/%{npm_name}
 cp -pf README.md ../../
 # If any binaries are included, symlink them to bindir here
 
-
-%nodejs_symlink_deps
-
 %if 0%{?enable_tests}
 %check
 %{nodejs_symlink_deps} --check
@@ -58,7 +52,6 @@ cp -pf README.md ../../
 %files
 %{nodejs_sitelib}/%{npm_name}
 
-%doc LICENSE
 %doc README.md
 
 %changelog
diff --git a/nodejs-webpack/nodejs-bundle-webpack.spec b/nodejs-webpack/nodejs-webpack.spec
similarity index 99%
rename from nodejs-webpack/nodejs-bundle-webpack.spec
rename to nodejs-webpack/nodejs-webpack.spec
index c00e921..5e7fa94 100644
--- a/nodejs-webpack/nodejs-bundle-webpack.spec
+++ b/nodejs-webpack/nodejs-webpack.spec
@@ -1,6 +1,3 @@
-# FIXME
-# Remove nodejs_symlink_deps if installing bundled module with NPM
-
 %global npm_name webpack
 %global enable_tests 0
 
@@ -629,8 +626,8 @@ Provides: bundled-npm(ecc-jsbn) = 0.1.1
 Provides: bundled-npm(tweetnacl) = 0.14.5
 Provides: bundled-npm(is-number) = 3.0.0
 Provides: bundled-npm(kind-of) = 4.0.0
-AutoReq: no 
-AutoProv: no 
+AutoReq: no
+AutoProv: no
 
 
 %description
@@ -650,17 +647,14 @@ npm install --cache-min Infinity --cache . --no-optional --global-style true %{n
 %install
 mkdir -p %{buildroot}%{nodejs_sitelib}/%{npm_name}
 cd node_modules/webpack
-cp -pfr LICENSE README.md bin buildin hot lib package.json schemas web_modules node_modules %{buildroot}%{nodejs_sitelib}/%{npm_name}
+cp -pfr README.md bin buildin hot lib package.json schemas web_modules node_modules %{buildroot}%{nodejs_sitelib}/%{npm_name}
 cp -pf README.md ../../
 # If any binaries are included, symlink them to bindir here
-mkdir -p %{buildroot}%{nodejs_sitelib}/${npm_name}/bin 
-mkdir -p %{buildroot}%{_bindir}/ 
+mkdir -p %{buildroot}%{nodejs_sitelib}/${npm_name}/bin
+mkdir -p %{buildroot}%{_bindir}/
 install -p -D -m0755 bin/webpack.js %{buildroot}%{nodejs_sitelib}/%{npm_name}/bin/webpack.js
 ln -sf %{nodejs_sitelib}/%{npm_name}/bin/webpack.js %{buildroot}%{_bindir}/webpack.js
 
-
-%nodejs_symlink_deps
-
 %if 0%{?enable_tests}
 %check
 %{nodejs_symlink_deps} --check
@@ -670,7 +664,6 @@ ln -sf %{nodejs_sitelib}/%{npm_name}/bin/webpack.js %{buildroot}%{_bindir}/webpa
 %files
 %{nodejs_sitelib}/%{npm_name}
 %{_bindir}/webpack.js
-%doc LICENSE
 %doc README.md
 
 %changelog

ohadlevy · 2017-07-11T09:26:51Z

@ehelms I've applied your changes.

ehelms · 2017-07-12T00:34:42Z

[test]

ehelms · 2017-07-12T19:04:54Z

Thanks @ohadlevy . The webpack package is passing so I expect the plugins to also pass as they did locally. Merging and will build.

theforeman-bot added Needs testing Not yet reviewed labels Jun 22, 2017

ohadlevy force-pushed the webpack3 branch from c807ade to 12acc75 Compare June 22, 2017 09:54

ohadlevy added the After core merge label Jun 22, 2017

ohadlevy mentioned this pull request Jun 26, 2017

Fixes #19478 - migrate to webpack2 theforeman/foreman#4514

Merged

ohadlevy removed the After core merge label Jun 26, 2017

ohadlevy force-pushed the webpack3 branch from 12acc75 to 2408539 Compare July 10, 2017 19:16

ohadlevy force-pushed the webpack3 branch from 2408539 to 6cc1507 Compare July 11, 2017 09:17

update webpack to v3.0

c506e6c

ohadlevy force-pushed the webpack3 branch from 6cc1507 to c506e6c Compare July 12, 2017 18:41

ehelms merged commit 49602d6 into theforeman:rpm/develop Jul 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update webpack to v3.0 #1693

update webpack to v3.0 #1693

ohadlevy commented Jun 22, 2017

dLobatog commented Jun 23, 2017

ohadlevy commented Jun 24, 2017

ohadlevy commented Jun 24, 2017

ohadlevy commented Jun 26, 2017

ehelms commented Jun 26, 2017

ehelms commented Jul 4, 2017

ehelms commented Jul 5, 2017

mmoll commented Jul 10, 2017

ohadlevy commented Jul 10, 2017

ehelms commented Jul 10, 2017

ehelms commented Jul 10, 2017

ehelms commented Jul 11, 2017

ohadlevy commented Jul 11, 2017

ehelms commented Jul 12, 2017

ehelms commented Jul 12, 2017

update webpack to v3.0 #1693

update webpack to v3.0 #1693

Conversation

ohadlevy commented Jun 22, 2017

dLobatog commented Jun 23, 2017

ohadlevy commented Jun 24, 2017

ohadlevy commented Jun 24, 2017

ohadlevy commented Jun 26, 2017

ehelms commented Jun 26, 2017

ehelms commented Jul 4, 2017

ehelms commented Jul 5, 2017

mmoll commented Jul 10, 2017

ohadlevy commented Jul 10, 2017

ehelms commented Jul 10, 2017

ehelms commented Jul 10, 2017

ehelms commented Jul 11, 2017

ohadlevy commented Jul 11, 2017

ehelms commented Jul 12, 2017

ehelms commented Jul 12, 2017