-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #19478 - migrate to webpack2 #4514
Conversation
storybook works fine as well. |
package.json
Outdated
@@ -56,6 +56,7 @@ | |||
"jstz": "~1.0.7", | |||
"lodash": "~4.15.0", | |||
"multiselect": "~0.9.12", | |||
"fbjs": "0.8.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it required by webpack2 now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[test foreman] |
[test katello] |
package.json
Outdated
@@ -36,7 +35,7 @@ | |||
"stats-webpack-plugin": "^0.2.1", | |||
"style-loader": "^0.13.1", | |||
"url-loader": "^0.5.7", | |||
"webpack": "^1.9.11", | |||
"webpack": "^2.5.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when testing it i got:
error extract-text-webpack-plugin@2.1.0: The engine "node" is incompatible with this module. Expected version ">=4.3.0 < 5.0.0 || >= 5.10".
error Found incompatible module
any idea what are the new minimum requirements? I assume this is going to effect our build infra too.
/cc @tbrisker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably a local issue that i had node v5.0.0 by mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matanwerbner 2.6.1 is already the latest, can you revisit all the dependencies mentioned here?
@matanwerbner I've noticed its slower, do you think wepack v2 is ready for "production"? |
@ohadlevy it is definatley pro |
Definatley prod ready although i seen many user experiencing slower build times, and reverting to v1 (which is officialy deprecated). |
package.json
Outdated
@@ -36,7 +35,7 @@ | |||
"stats-webpack-plugin": "^0.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to bump version
also need to change the - webpack.optimize.OccurenceOrderPlugin(), to webpack.optimize.OccurrenceOrderPlugin |
@matanwerbner I've been using it over a week on my instance without a significant impact, I'm fine with merging this. |
eb7c1ef
to
7dd7ad7
Compare
@ohadlevy i have rebased, feel free to merge :) |
7dd7ad7
to
ba0ddd6
Compare
@ohadlevy tests are good |
@matanwerbner seems to work, I am however seeing the following:
|
setting as WoC as I'm still getting
|
ba0ddd6
to
f67e280
Compare
should we wait? https://twitter.com/TheLarkInn/status/876853489049010176 |
guess so... 😆 |
f67e280
to
66df468
Compare
@ohadlevy it's v3 now, no improvement in the file size, however bundle is structured a bit differently, in a way that is supposed to improve performance. |
nice! can you just address:
|
we need to watch this space: |
I also see
should we bump extract-text version? |
@ohadlevy we are at latest, nowhere to bump. |
also..
|
@ohadlevy should we go back to v2, and wait for 3 to stabilize? |
On Thu, Jun 22, 2017 at 10:52 AM, matanwerbner ***@***.***> wrote:
@ohadlevy <https://github.com/ohadlevy> should we go back to v2, and wait
for 3 to stabilize?
I'm running v3 in prod since your PR with no issues - is it simply a
warning that we can ignore or more than that?
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4514 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOx3VkiZ8eaQcyfsgb606XVmrfj8wqks5sGh1DgaJpZM4NVA0B>
.
|
Hard to say, it seems like no braking changes have occured, i however would feel more comfortable to wait with it. |
thanks @matanwerbner |
packaging pr at theforeman/foreman-packaging#1693 |
This was needed as a workaround[1] that's no longer needed. [1]: theforeman#4514 (comment)
This was needed as a workaround[1] that's no longer needed. [1]: #4514 (comment)
This was needed as a workaround[1] that's no longer needed. [1]: theforeman#4514 (comment)
As webpack 1 is being deprecated, we better migrate to 2 to have full support and updates.