Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #21774 - Drop fbjs requirement #5029

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Fixes #21774 - Drop fbjs requirement #5029

merged 1 commit into from
Nov 27, 2017

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 27, 2017

This was needed as a workaround that's no longer needed.

@ekohl
Fixes #21774 - Drop fbjs requirement
a1d2dbc 
This was needed as a workaround[1] that's no longer needed.

[1]: theforeman#4514 (comment)
@theforeman-bot
Copy link
Member

Issues: #21774

@ekohl ekohl mentioned this pull request Nov 27, 2017
Merged
dLobatog
dLobatog approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 provided tests pass

@tbrisker tbrisker merged commit cb3d716 into theforeman:develop Nov 27, 2017
@tbrisker
Copy link
Member

Thanks @ekohl !

@ekohl ekohl deleted the 21774-fbjs branch November 27, 2017 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dLobatog dLobatog dLobatog approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekohl @theforeman-bot @tbrisker @dLobatog