-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37519 - Host form - Libvirt improvements #10190
base: develop
Are you sure you want to change the base?
Conversation
stejskalleos
commented
May 30, 2024
•
edited
Loading
edited
- Provisioning a host with an image that does not exist has the correct error.
- Fixed error for the Libvirt capacity storage.
- Added error to the field when the image is not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm tempted to ask to split this up so they show up as individual bug fixes in the changelog.
not sure how to recreate the bug, and the pr needs splitting but the .erb and .js code looks ok |
Updated and split into two (#10232) |
@stejskalleos What is exactly fixed here? I'm not sure how to test that. Update: I see now that |
@nofaralfasi I don't have that problem, when I set 33G size, then it works as expected:
|
That's my point. The result is not affected by the JS code inside the How did you test it? Did you use network-based or image-based provisioning? Keep in mind that this function is only triggered during image-based provisioning. |
I accidentally closed the PR :) |
Even when I use imaged-based provisioning (qcow2 image), it works fine for me. |
- Provisioning a host with an image that does not exist has the correct error. - Fixed error for the Libvirt capacity storage. - Added error to the field when the image is not found - Fix automatic change of storage type and size
f736012
to
af20b8e
Compare
Random thought: could it be thin provisioning? |