-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37615 - Improve help text for the PXE loader in the Host form #10232
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lennonka would you mind having a look? I think the whole help text we had doesn't cover the exact use case, but the newly suggested one is also not obvious to me.
I think the use OS parameter 'pxe-loader' to override
part is confusing. Why do you have a select to choose something, but tell users how they can override it at the OS level?
AFAIK this option determines how we configure the network boot environment (DHCP, TFTP) and in case of VMware also the VM configuration.
@@ -1,3 +1,7 @@ | |||
<% | |||
help = _("DHCP filename option to use. Set to None for non-PXE method (e.g. iPXE). Auto-suggested, use OS parameter 'pxe-loader' to override.") | |||
help2 = _("This option specifies the file to be loaded via TFTP during PXE boot. It does not affect the initial boot method (BIOS/UEFI/GRUB/PXE) but configures the file and DHCP options for the network boot.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the last part is true, because AFAIK at least for VMware we configure the VM (by default) based on this option. In #9965 I copied this pattern to libvirt, but that's not merged right now.
I observe a couple of problems with this field:
IMO, this is the part where the user actually tells Foreman what network boot capabilities the host has and how Foreman should attempt to boot it. I think that should be the central information in this context help. How about something like the following: Configure DHCP filename to boot the host with the given firmware (BIOS/UEFI) over the network. Set to None for non-PXE booting (eg. iPXE, bootdisk). For reference: https://docs.theforeman.org/nightly/Provisioning_Hosts/index-katello.html#DHCP_Options_provisioning I may need to think about this a bit more too. The above suggestion isn't final. |
This shows up in the Host form for, but also in the Host Group form. It looks like this: My reading of the Foreman code is that this happens:
|
No description provided.